Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-1.11] Fix cluster scope resources #1511

Merged
merged 2 commits into from
Jul 31, 2023
Merged

[release-1.11] Fix cluster scope resources #1511

merged 2 commits into from
Jul 31, 2023

Conversation

knative-prow-robot
Copy link
Contributor

This is an automated cherry-pick of #1510

@knative-prow-robot knative-prow-robot mentioned this pull request Jul 29, 2023
Merged
@knative-prow knative-prow bot requested review from matzew and maximilien July 29, 2023 02:45
@knative-prow knative-prow bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 29, 2023
@houshengbo
Copy link
Contributor

/lgtm
/approve

@knative-prow knative-prow bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 29, 2023
@codecov
Copy link

codecov bot commented Jul 29, 2023 •
edited
Loading

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.06% 🎉

Comparison is base (0a438bc) 79.15% compared to head (3703606) 79.22%.

Additional details and impacted files 
@@               Coverage Diff                @@
##           release-1.11    #1511      +/-   ##
================================================
+ Coverage         79.15%   79.22%   +0.06%     
================================================
  Files                40       40              
  Lines              1794     1800       +6     
================================================
+ Hits               1420     1426       +6     
  Misses              272      272              
  Partials            102      102
Files Changed Coverage Δ
pkg/reconciler/common/transformers.go 82.60% <100.00%> (+2.60%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

matzew
matzew approved these changes Jul 31, 2023
View reviewed changes
Copy link
Member

@matzew matzew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

/retest

@knative-prow
Copy link

knative-prow bot commented Jul 31, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: houshengbo, knative-prow-robot, matzew

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit 0575636 into knative:release-1.11 Jul 31, 2023
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matzew matzew matzew approved these changes

@maximilien maximilien Awaiting requested review from maximilien

Assignees

@matzew matzew

@houshengbo houshengbo

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@knative-prow-robot @houshengbo @matzew