Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cluster scope resources #1510

Merged
merged 2 commits into from
Jul 28, 2023

Conversation

houshengbo
Copy link
Contributor

Fixes #1509

@knative-prow knative-prow bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 28, 2023
@knative-prow knative-prow bot requested review from matzew and maximilien July 28, 2023 17:16
Copy link

@knative-prow knative-prow bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@houshengbo: 0 warnings.

In response to this:

Fixes #1509

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@codecov
Copy link

codecov bot commented Jul 28, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.06% 🎉

Comparison is base (0a438bc) 79.15% compared to head (eead8c1) 79.22%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1510      +/-   ##
==========================================
+ Coverage   79.15%   79.22%   +0.06%     
==========================================
  Files          40       40              
  Lines        1794     1800       +6     
==========================================
+ Hits         1420     1426       +6     
  Misses        272      272              
  Partials      102      102              
Files Changed Coverage Δ
pkg/reconciler/common/transformers.go 82.60% <100.00%> (+2.60%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@houshengbo
Copy link
Contributor Author

/test eventing-upgrade-tests

@dprotaso
Copy link
Member

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jul 28, 2023
@knative-prow
Copy link

knative-prow bot commented Jul 28, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, houshengbo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [dprotaso,houshengbo]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit ce2ef23 into knative:main Jul 28, 2023
17 checks passed
@houshengbo
Copy link
Contributor Author

/cherry-pick release-1.11

@knative-prow-robot
Copy link
Contributor

@houshengbo: new pull request created: #1511

In response to this:

/cherry-pick release-1.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Avoid injecting the owner for all cluster scoped resources based on 0.7.2 Manifestival
3 participants