Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add replica config #869

Merged
merged 1 commit into from
Mar 8, 2019
Merged

Conversation

matzew
Copy link
Member

@matzew matzew commented Mar 8, 2019

Fixes #863

Proposed Changes

  • adding config for replica, instead hard coded to 1

Release Note

Kafka Channels can configure their replication factor with the `ReplicationFactor` arg.

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Mar 8, 2019
@knative-prow-robot knative-prow-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 8, 2019
@matzew
Copy link
Member Author

matzew commented Mar 8, 2019

@nak3 mind to take a look ?

/assign nak3

@knative-prow-robot
Copy link
Contributor

@matzew: GitHub didn't allow me to assign the following users: nak3.

Note that only knative members and repo collaborators can be assigned.
For more information please see the contributor guide

In response to this:

@nak3 mind to take a look ?

/assign nak3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-metrics-robot
Copy link

The following is the coverage report on pkg/.
Say /test pull-knative-eventing-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
contrib/kafka/pkg/controller/channel/reconcile.go 76.6% 76.9% 0.3

@nak3
Copy link
Contributor

nak3 commented Mar 8, 2019

@matzew LGTM
(I wondered why it was hard coded, but it looks like there was the plan to update #468 (comment) and seems no side effect for this change.)

@vaikas
Copy link
Contributor

vaikas commented Mar 8, 2019

/lgtm
/approve

Are there any documentation changes that should be done for this also?

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 8, 2019
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matzew, vaikas-google

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 8, 2019
@knative-prow-robot knative-prow-robot merged commit 55e0b84 into knative:master Mar 8, 2019
creydr pushed a commit to creydr/knative-eventing that referenced this pull request Sep 18, 2024
Co-authored-by: pierDipi <pierDipi@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants