Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kafka channel ReplicationFactor #863

Closed
matzew opened this issue Mar 7, 2019 · 2 comments
Closed

Kafka channel ReplicationFactor #863

matzew opened this issue Mar 7, 2019 · 2 comments
Assignees
@matzew

Comments

@matzew
Copy link
Member

matzew commented Mar 7, 2019

Expected Behavior

provide args for ReplicationFactor of a topic (via channel)

Actual Behavior

not possible
@matzew
Copy link
Member Author

matzew commented Mar 7, 2019

/assign

@matzew
Copy link
Member Author

matzew commented Mar 7, 2019

The replications is hard coded to 1, while the number of partions is configurable

https://github.com/knative/eventing/blob/master/contrib/kafka/pkg/controller/channel/reconcile.go#L205-L207

@matzew matzew mentioned this issue Mar 8, 2019
Merged
matzew added a commit to matzew/eventing that referenced this issue Oct 1, 2020
@matzew
Merge pull request knative#863 from matzew/fqn_image_second_try_0.16
95df750 
[0.16] using fqn image name
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@matzew matzew

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@matzew