-
Notifications
You must be signed in to change notification settings - Fork 592
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Authenticate Requests from ApiServerSources #7452
Authenticate Requests from ApiServerSources #7452
Conversation
Skipping CI for Draft Pull Request. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #7452 +/- ##
==========================================
- Coverage 76.19% 75.53% -0.66%
==========================================
Files 260 261 +1
Lines 14447 14667 +220
==========================================
+ Hits 11008 11079 +71
- Misses 2873 3008 +135
- Partials 566 580 +14 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Leo Li <leoli@redhat.com>
Signed-off-by: Leo Li <leoli@redhat.com>
Signed-off-by: Leo Li <leoli@redhat.com>
pkg/reconciler/inmemorychannel/controller/resources/role_binding.go
Outdated
Show resolved
Hide resolved
Signed-off-by: Leo Li <leoli@redhat.com>
Co-authored-by: Christoph Stäbler <cstabler@redhat.com>
Co-authored-by: Calum Murray <cmurray@redhat.com>
Signed-off-by: Leo Li <leoli@redhat.com>
…r for the role and rolebinding informers Signed-off-by: Leo Li <leoli@redhat.com>
bb7c0d6
to
479aa7f
Compare
…r for the role and rolebinding informers Signed-off-by: Leo Li <leoli@redhat.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some comments on the role & rolebinding event handler filters.
You also need to adjust the tests too (added labels and later with the new owner reference)
Signed-off-by: Leo Li <leoli@redhat.com>
Signed-off-by: Leo Li <leoli@redhat.com>
Signed-off-by: Leo Li <leoli@redhat.com>
Signed-off-by: Leo Li <leoli@redhat.com>
Signed-off-by: Leo Li <leoli@redhat.com>
Signed-off-by: Leo Li <leoli@redhat.com>
…using only the selector oidc) and not by value Signed-off-by: Leo Li <leoli@redhat.com>
…using only the selector oidc) and not by value Signed-off-by: Leo Li <leoli@redhat.com>
Signed-off-by: Leo Li <leoli@redhat.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: creydr, Leo6Leo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Fixes #7321
Proposed Changes
Prerequisite: When OIDC mode is enabled and sink has audience
Pre-review Checklist
Release Note
Docs