nit: fix the naming and add - to the create-oidc-token

Signed-off-by: Leo Li <leoli@redhat.com>
knative · Dec 18, 2023 · 8890c5d · 8890c5d
1 parent a73a26b
commit 8890c5d
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/pkg/apis/sources/register.go b/pkg/apis/sources/register.go
@@ -33,6 +33,7 @@ const (
 	// the CRD is a Source duck type.
 	SourceDuckLabelValue = "true"
 
+	//OIDCLabelKey is used to filter out all the informers that related to OIDC work
 	OIDCLabelKey = "oidc"
 
 	// OIDCTokenRoleLabelSelector is the label selector for the OIDC token creator role and rolebinding informers

diff --git a/pkg/reconciler/apiserversource/resources/oidc_rolebinding.go b/pkg/reconciler/apiserversource/resources/oidc_rolebinding.go
@@ -30,12 +30,12 @@ import (
 
 // GetOIDCTokenRoleName will return the name of the role for creating the JWT token
 func GetOIDCTokenRoleName(sourceName string) string {
-	return kmeta.ChildName(sourceName, "create-oidc-token")
+	return kmeta.ChildName(sourceName, "-create-oidc-token")
 }
 
 // GetOIDCTokenRoleBindingName will return the name of the rolebinding for creating the JWT token
 func GetOIDCTokenRoleBindingName(sourceName string) string {
-	return kmeta.ChildName(sourceName, "create-oidc-token")
+	return kmeta.ChildName(sourceName, "-create-oidc-token")
 }
 
 // MakeOIDCRole will return the role object config for generating the JWT token