Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using HorizontalPodAutoscaler v2 #6549

Merged
merged 2 commits into from
Sep 30, 2022
Merged

Using HorizontalPodAutoscaler v2 #6549

merged 2 commits into from
Sep 30, 2022

Conversation

matzew
Copy link
Member

@matzew matzew commented Sep 28, 2022

Fixes #6332

Proposed Changes

  • Using HorizontalPodAutoscaler v2, since v2beta2 is being deprecated in k8s 1.23 (our next min-version)

Pre-review Checklist

  • At least 80% unit test coverage
  • E2E tests for any new behavior
  • Docs PR for any user-facing impact
  • Spec PR for any new API feature
  • Conformance test for any change to the spec

Release Note

The HorizontalPodAutoscaler manifests have been updated to v2, which is available with k8s 1.23+

Docs

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>
@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 28, 2022
@matzew
Copy link
Member Author

matzew commented Sep 28, 2022

/hold
Holding for a few reasons:

@knative-prow knative-prow bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 28, 2022
@codecov
Copy link

codecov bot commented Sep 28, 2022

Codecov Report

Base: 81.94% // Head: 81.94% // No change to project coverage 👍

Coverage data is based on head (0fd8361) compared to base (bd37622).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6549   +/-   ##
=======================================
  Coverage   81.94%   81.94%           
=======================================
  Files         235      235           
  Lines       11738    11738           
=======================================
  Hits         9619     9619           
  Misses       1646     1646           
  Partials      473      473           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@lionelvillard
Copy link
Member

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Sep 28, 2022
@knative-prow
Copy link

knative-prow bot commented Sep 28, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lionelvillard, matzew

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [lionelvillard,matzew]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@matzew
Copy link
Member Author

matzew commented Sep 30, 2022

/unhold

@knative-prow knative-prow bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 30, 2022
@knative-prow knative-prow bot merged commit abe0a57 into knative:main Sep 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bump HorizontalPodAutoscaler from deprecated v2beta2 to v2
2 participants