Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump HorizontalPodAutoscaler from deprecated v2beta2 to v2 #6332

Closed
pierDipi opened this issue Apr 14, 2022 · 9 comments · Fixed by #6549
Closed

Bump HorizontalPodAutoscaler from deprecated v2beta2 to v2 #6332

pierDipi opened this issue Apr 14, 2022 · 9 comments · Fixed by #6549
Assignees
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature-request triage/accepted Issues which should be fixed (post-triage)

Comments

@pierDipi
Copy link
Member

Problem

I'm getting this warning on k8s 1.23:

Warning: autoscaling/v2beta2 HorizontalPodAutoscaler is deprecated in v1.23+, unavailable in v1.26+; use autoscaling/v2 HorizontalPodAutoscaler

on

Client Version: version.Info{Major:"1", Minor:"22", GitVersion:"v1.22.0", GitCommit:"c2b5237ccd9c0f1d600d3072634ca66cefdf272f", GitTreeState:"clean", BuildDate:"2021-08-04T18:03:20Z", GoVersion:"go1.16.6", Compiler:"gc", Platform:"linux/amd64"}
Server Version: version.Info{Major:"1", Minor:"23", GitVersion:"v1.23.3", GitCommit:"816c97ab8cff8a1c72eccca1026f7820e93e0d25", GitTreeState:"clean", BuildDate:"2022-01-26T08:02:07Z", GoVersion:"go1.17.6", Compiler:"gc", Platform:"linux/amd64"}

Persona:
Which persona is this feature for?
*

Exit Criteria
A measurable (binary) test that would indicate that the problem has been resolved.

Time Estimate (optional):
How many developer-days do you think this may take to resolve?
1

@pierDipi
Copy link
Member Author

pierDipi commented May 2, 2022

/triage accepted
/good-first-issue

@knative-prow
Copy link

knative-prow bot commented May 2, 2022

@pierDipi:
This request has been marked as suitable for new contributors.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

/triage accepted
/good-first-issue

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow knative-prow bot added triage/accepted Issues which should be fixed (post-triage) good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels May 2, 2022
@gab-satchi
Copy link
Contributor

/assign

@gab-satchi
Copy link
Contributor

Hey @pierDipi, I think this needs to wait till after v1.6. Any way to move to that release?

The minimum supported k8s version for v1.6 is still v1.22 and autoscaling/v2 isn't available in that k8s release.

@liuchangyan
Copy link
Contributor

@gab-satchi Hi, are you still working on this issue ? if not, I would like to take it.

@pierDipi
Copy link
Member Author

Hi @liuchangyan, this needs to wait for a min k8s version bump due to #6424 (comment).

This min k8s version bump is supposed to happen in 1.7 (today we are releasing 1.6), so we can start this after we have removed 1.22 from the KinD testing matrix and added 1.24

@amaanq
Copy link

amaanq commented Sep 21, 2022

is this still open and available to be taken?

@pierDipi
Copy link
Member Author

Hi @amaanq, yes, this is available to be taken

@matzew matzew changed the title Bump deprecated autoscaling/v2beta2 HorizontalPodAutoscaler to autoscaling/v2 HorizontalPodAutoscaler Bump HorizontalPodAutoscaler from deprecated v2beta2 to v2 Sep 23, 2022
@matzew
Copy link
Member

matzew commented Sep 27, 2022

@amaanq still interested in this? Otherwise I will take it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature-request triage/accepted Issues which should be fixed (post-triage)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants