Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test trigger delivery specs fully #5268

Merged
merged 4 commits into from
Apr 19, 2021
Merged

test trigger delivery specs fully #5268

merged 4 commits into from
Apr 19, 2021

Conversation

n3wscott
Copy link
Contributor

@n3wscott n3wscott commented Apr 15, 2021 •
edited
Loading

@google-cla google-cla bot added the cla: yes Indicates the PR's author has signed the CLA. label Apr 15, 2021
@knative-prow-robot knative-prow-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. area/test-and-release Test infrastructure, tests or release labels Apr 15, 2021
@codecov
Copy link

codecov bot commented Apr 15, 2021 •
edited
Loading

Codecov Report

Merging #5268 (dbbcb1b) into main (e745733) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #5268   +/-   ##
=======================================
  Coverage   83.34%   83.34%           
=======================================
  Files         243      243           
  Lines        6882     6882           
=======================================
  Hits         5736     5736           
  Misses        797      797           
  Partials      349      349

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e745733...dbbcb1b. Read the comment docs.

vaikas
vaikas reviewed Apr 15, 2021
View reviewed changes
test/rekt/broker_test.go Outdated Show resolved Hide resolved
vaikas
vaikas approved these changes Apr 15, 2021
View reviewed changes
Copy link
Contributor

@vaikas vaikas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow-robot knative-prow-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 15, 2021
@n3wscott
Copy link
Contributor Author

/retest

@knative-prow-robot knative-prow-robot removed the lgtm Indicates that a PR is ready to be merged. label Apr 16, 2021
@n3wscott
Copy link
Contributor Author

/retest

hm maybe a timing issue on that one too

@n3wscott
Copy link
Contributor Author

/assign @vaikas

vaikas
vaikas approved these changes Apr 19, 2021
View reviewed changes
Copy link
Contributor

@vaikas vaikas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 19, 2021
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vaikas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit cd7c750 into knative:main Apr 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vaikas vaikas vaikas approved these changes

Assignees

@vaikas vaikas

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release Test infrastructure, tests or release cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@n3wscott @knative-prow-robot @vaikas