Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make sure the mtchannelbasedbroker uses trigger.spec.delivery #5267

Merged
merged 2 commits into from
Apr 15, 2021

Conversation

n3wscott
Copy link
Contributor

Fixes #5266

Proposed Changes

  • 🐛 Propagate trigger.spec.delivery to subscriptions for MTChannelBasedBroker.

Release Note

Bug fix: Propagate trigger.spec.delivery to subscriptions for MTChannelBasedBroker.

@google-cla google-cla bot added the cla: yes Indicates the PR's author has signed the CLA. label Apr 15, 2021
@knative-prow-robot knative-prow-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Apr 15, 2021
@codecov
Copy link

codecov bot commented Apr 15, 2021

Codecov Report

Merging #5267 (8c7c2fc) into main (71153e6) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #5267   +/-   ##
=======================================
  Coverage   83.34%   83.34%           
=======================================
  Files         243      243           
  Lines        6879     6882    +3     
=======================================
+ Hits         5733     5736    +3     
  Misses        797      797           
  Partials      349      349           
Impacted Files Coverage Δ
pkg/reconciler/broker/trigger/trigger.go 80.45% <100.00%> (+0.45%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 71153e6...8c7c2fc. Read the comment docs.

@n3wscott n3wscott mentioned this pull request Apr 15, 2021
1 task
@knative-metrics-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-knative-eventing-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/broker/trigger/trigger.go 86.1% 86.4% 0.4

@n3wscott
Copy link
Contributor Author

related to #4515
related to #4654

Copy link
Contributor

@vaikas vaikas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 15, 2021
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vaikas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 15, 2021
@knative-prow-robot knative-prow-robot merged commit e745733 into knative:main Apr 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MTChannelBasedBroker impl ignores trigger.spec.delivery when creating subscriptions.
4 participants