Implement #4057 Channeleable.Delivery

[slinkydeveloper]

Signed-off-by: Francesco Guardiani francescoguard@gmail.com

Fixes #4057

Proposed Changes

• 🐛 Fix propagation of channelable spec of channel to the physical channel
• 🎁 Implement Unused Delivery in the ChannelableSpec #4057 as proposed in the spec pr Fix spec issue as discussed in #4057 #4650

Release Note

Now setting the channel spec delivery field defaults every subscription to that particular delivery spec

Docs

[codecov]

Codecov Report

Merging #4652 (6458805) into master (1e06e5c) will decrease coverage by 0.23%.
The diff coverage is 49.05%.

@@            Coverage Diff             @@
##           master    #4652      +/-   ##
==========================================
- Coverage   81.31%   81.07%   -0.24%     
==========================================
  Files         290      291       +1     
  Lines        8176     8212      +36     
==========================================
+ Hits         6648     6658      +10     
- Misses       1128     1153      +25     
- Partials      400      401       +1     

Impacted Files	Coverage Δ
pkg/apis/duck/v1/channelable_types.go	97.95% <ø> (ø)
pkg/apis/duck/v1/register.go	100.00% <ø> (ø)
pkg/apis/duck/v1alpha1/register.go	100.00% <ø> (ø)
pkg/apis/eventing/v1/broker_lifecycle_mt.go	100.00% <ø> (ø)
pkg/apis/eventing/v1/broker_types.go	66.66% <ø> (ø)
pkg/apis/eventing/v1/register.go	80.00% <ø> (ø)
pkg/apis/eventing/v1/test_helper.go	83.33% <ø> (ø)
pkg/apis/eventing/v1/trigger_defaults.go	100.00% <ø> (ø)
pkg/apis/eventing/v1/trigger_lifecycle.go	45.00% <ø> (ø)
pkg/apis/eventing/v1/trigger_types.go	100.00% <ø> (ø)
... and 57 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1e06e5c...93b3c0a. Read the comment docs.

[slinkydeveloper]

/assign @vaikas

[knative-metrics-robot]

The following is the coverage report on the affected files.
Say /test pull-knative-eventing-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/messaging/v1/channel_template_types.go	Do not exist	0.0%
pkg/reconciler/subscription/subscription.go	76.2%	76.6%	0.4

[knative-prow-robot]

@slinkydeveloper: The following test failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
pull-knative-eventing-go-coverage	93b3c0a	link	/test pull-knative-eventing-go-coverage

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[vaikas]

/lgtm
/approve

[knative-prow-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: slinkydeveloper, vaikas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [slinkydeveloper,vaikas]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment