Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup the api packages to remove unused duck templates #4728

Closed
slinkydeveloper opened this issue Jan 12, 2021 · 4 comments
Closed

Cleanup the api packages to remove unused duck templates #4728

slinkydeveloper opened this issue Jan 12, 2021 · 4 comments
Assignees
Labels
area/channels area/sources kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.

Comments

@slinkydeveloper
Copy link
Contributor

Describe the bug
In a previous PR #4652 I've found out there are some types we don't need anymore between the templates, some of them probably doesn't even need to be versioned following the k8s convention.

Expected behavior
Cleanup that code

/assign

@slinkydeveloper slinkydeveloper added the kind/bug Categorizes issue or PR as related to a bug. label Jan 12, 2021
@lberk lberk added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. and removed kind/bug Categorizes issue or PR as related to a bug. labels Jan 25, 2021
@lberk
Copy link
Member

lberk commented Jan 25, 2021

@slinkydeveloper just looking at the age of the issue, is this something you're actively working on? (trying to determine the best milestone to put this in)

@lberk lberk added priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. area/channels area/sources labels Jan 25, 2021
@lberk
Copy link
Member

lberk commented Jan 25, 2021

also, just a quick word of caution (via Scott), lets be careful with what we remove considering the number of places eventing is vendor'd (both what we know, knative-sandbox) as well as others we don't know about.

@slinkydeveloper
Copy link
Contributor Author

I already fixed that, but i forgot to link the PR: #4749

/close

@knative-prow-robot
Copy link
Contributor

@slinkydeveloper: Closing this issue.

In response to this:

I already fixed that, but i forgot to link the PR: #4749

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/channels area/sources kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.
Projects
None yet
Development

No branches or pull requests

3 participants