feat/perf-test: update README and broker-imc benchmark #4607

zhongduo · 2020-11-27T16:57:37Z

Proposed Changes

Update README to use perf-eventing namespace
Update benchmark configuration

codecov · 2020-11-27T17:05:04Z

Codecov Report

Merging #4607 (b084909) into master (ad755bd) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #4607   +/-   ##
=======================================
  Coverage   81.31%   81.31%           
=======================================
  Files         290      290           
  Lines        8176     8176           
=======================================
  Hits         6648     6648           
  Misses       1128     1128           
  Partials      400      400

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad755bd...5f07679. Read the comment docs.

test/performance/README.md

tommyreddad · 2020-11-27T18:26:46Z

test/performance/README.md

-   configured with a single benchmark.
+1. Create a namespace `perf-eventing` if not exists. To use a different
+   namespace, pleaes replace all the namespaces in
+   all bash commands and yaml configuration files with your choice.

 1. Install Knative eventing by following the steps in
   https://github.com/knative/eventing/blob/2c6bf0526634804b7ebeee686445901440cc8edd/test/performance/performance-tests.sh#L31


Is it still relevant to recommend following this script which is not up-to-date?

Good point, I personally didn't check this at all. I simply install knative eventing myself. Should we just change it to "install Knative eventing and components under test such as MT broker"?

I think that would be a good idea, and link to DEVELOPMENT.md

tommyreddad · 2020-11-27T18:28:00Z

test/performance/README.md

 1. Retrieve results from mako-stub using the script in
-   [knative/pkg](https://github.com/knative/pkg/blob/master/test/mako/stub-sidecar/read_results.sh):
+   [knative/pkg](https://github.com/knative/pkg/blob/master/test/mako/stub-sidecar/read_results.sh)
+   where `pod_name` is the name of the aggreator pod:

   ```
   bash "$GOPATH/src/knative.dev/pkg/test/mako/stub-sidecar/read_results.sh" "$pod_name" perf-eventing ${mako_port:-10001} ${timeout:-120} ${retries:-100} ${retries_interval:-10} "$output_file"


Since we are vendoring the mako stub, this path should be adjusted to the eventing vendor subdirectory.

tommyreddad · 2020-11-27T18:28:39Z

/assign

google-cla · 2020-11-27T18:33:06Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

googlebot · 2020-11-27T19:10:09Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

google-cla · 2020-11-27T21:34:21Z

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

google-cla · 2020-11-27T21:37:47Z

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

tommyreddad · 2020-11-27T22:01:18Z

/lgtm

test/performance/README.md

tayarani · 2020-11-30T14:01:31Z

test/performance/README.md

-   configured with a single benchmark.
+1. Create a namespace `perf-eventing` if not exists. To use a different
+   namespace, please replace all the namespaces in
+   all bash commands and yaml configuration files with your choice.


do u mean bash scripts here or is commands intended?

Command is commonly used to refer to one line script.

test/performance/README.md

tayarani · 2020-11-30T14:03:50Z

Some minor comments I'll leave up to you.

/lgtm

google-cla · 2020-11-30T14:29:54Z

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

tayarani · 2020-11-30T14:46:30Z

/lgtm

zhongduo · 2020-12-02T15:13:43Z

/assign @slinkydeveloper

slinkydeveloper · 2020-12-02T15:28:17Z

/lgtm

not sure about the meaning of mako stuff, looping @grantr for the final approval

zhongduo · 2020-12-02T15:35:24Z

@chizhg might have the context.

zhongduo · 2020-12-04T20:21:30Z

/assign @chizhg

chizhg · 2020-12-08T19:14:08Z

/approve

knative-prow-robot · 2020-12-08T19:14:19Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chizhg, zhongduo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~test/OWNERS~~ [chizhg]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

google-cla bot added the cla: yes Indicates the PR's author has signed the CLA. label Nov 27, 2020

knative-prow-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 27, 2020

knative-prow-robot requested review from steuhs and yt3liu November 27, 2020 16:57

knative-prow-robot added the area/test-and-release Test infrastructure, tests or release label Nov 27, 2020

feat/perf-test: update README and broker-imc benchmark

acbddc5

zhongduo force-pushed the fix-perf-test branch from 1dd84e3 to acbddc5 Compare November 27, 2020 17:03

tommyreddad reviewed Nov 27, 2020

View reviewed changes

knative-prow-robot assigned tommyreddad Nov 27, 2020

google-cla bot added cla: no Indicates the PR's author has not signed the CLA. and removed cla: yes Indicates the PR's author has signed the CLA. labels Nov 27, 2020

zhongduo force-pushed the fix-perf-test branch from 3c4f9ec to 60c1987 Compare November 27, 2020 21:34

google-cla bot added cla: yes Indicates the PR's author has signed the CLA. and removed cla: no Indicates the PR's author has not signed the CLA. labels Nov 27, 2020

zhongduo force-pushed the fix-perf-test branch from 60c1987 to 4627c8a Compare November 27, 2020 21:37

knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 27, 2020

tayarani reviewed Nov 30, 2020

View reviewed changes

test/performance/README.md Outdated Show resolved Hide resolved

tayarani reviewed Nov 30, 2020

View reviewed changes

test/performance/README.md Show resolved Hide resolved

knative-prow-robot assigned tayarani Nov 30, 2020

Resolve comments

5f07679

zhongduo force-pushed the fix-perf-test branch from 4627c8a to 5f07679 Compare November 30, 2020 14:29

knative-prow-robot removed the lgtm Indicates that a PR is ready to be merged. label Nov 30, 2020

knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 30, 2020

knative-prow-robot assigned slinkydeveloper Dec 2, 2020

knative-prow-robot assigned chizhg Dec 4, 2020

knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 8, 2020

knative-prow-robot merged commit ca2def5 into knative:master Dec 8, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat/perf-test: update README and broker-imc benchmark #4607

feat/perf-test: update README and broker-imc benchmark #4607

zhongduo commented Nov 27, 2020

codecov bot commented Nov 27, 2020 •

edited

Loading

tommyreddad Nov 27, 2020

zhongduo Nov 27, 2020

tommyreddad Nov 27, 2020

tommyreddad Nov 27, 2020

tommyreddad commented Nov 27, 2020

google-cla bot commented Nov 27, 2020

googlebot commented Nov 27, 2020

google-cla bot commented Nov 27, 2020

google-cla bot commented Nov 27, 2020

tommyreddad commented Nov 27, 2020

tayarani Nov 30, 2020

zhongduo Nov 30, 2020

tayarani commented Nov 30, 2020

google-cla bot commented Nov 30, 2020

tayarani commented Nov 30, 2020

zhongduo commented Dec 2, 2020

slinkydeveloper commented Dec 2, 2020

zhongduo commented Dec 2, 2020

zhongduo commented Dec 4, 2020

chizhg commented Dec 8, 2020

knative-prow-robot commented Dec 8, 2020

feat/perf-test: update README and broker-imc benchmark #4607

feat/perf-test: update README and broker-imc benchmark #4607

Conversation

zhongduo commented Nov 27, 2020

Proposed Changes

codecov bot commented Nov 27, 2020 • edited Loading

Codecov Report

tommyreddad Nov 27, 2020

Choose a reason for hiding this comment

zhongduo Nov 27, 2020

Choose a reason for hiding this comment

tommyreddad Nov 27, 2020

Choose a reason for hiding this comment

tommyreddad Nov 27, 2020

Choose a reason for hiding this comment

tommyreddad commented Nov 27, 2020

google-cla bot commented Nov 27, 2020

googlebot commented Nov 27, 2020

google-cla bot commented Nov 27, 2020

google-cla bot commented Nov 27, 2020

tommyreddad commented Nov 27, 2020

tayarani Nov 30, 2020

Choose a reason for hiding this comment

zhongduo Nov 30, 2020

Choose a reason for hiding this comment

tayarani commented Nov 30, 2020

google-cla bot commented Nov 30, 2020

tayarani commented Nov 30, 2020

zhongduo commented Dec 2, 2020

slinkydeveloper commented Dec 2, 2020

zhongduo commented Dec 2, 2020

zhongduo commented Dec 4, 2020

chizhg commented Dec 8, 2020

knative-prow-robot commented Dec 8, 2020

codecov bot commented Nov 27, 2020 •

edited

Loading