Skip to content

Commit

Permalink
Resolve comments
Browse files Browse the repository at this point in the history
  • Loading branch information
Jimmy Lin committed Nov 27, 2020
1 parent acbddc5 commit 60c1987
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions test/performance/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,11 +3,11 @@
## Configuring your cluster to run a benchmark

1. Create a namespace `perf-eventing` if not exists. To use a different
namespace, pleaes replace all the namespaces in
namespace, please replace all the namespaces in
all bash commands and yaml configuration files with your choice.

1. Install Knative eventing by following the steps in
https://github.com/knative/eventing/blob/2c6bf0526634804b7ebeee686445901440cc8edd/test/performance/performance-tests.sh#L31
1. Install Knative eventing and components used in the performance test,
such as MT broker, by following the steps in https://github.com/knative/eventing/blob/master/DEVELOPMENT.md.

1. Create a ConfigMap called `config-mako` in your chosen namespace containing
the Mako config file.
Expand Down Expand Up @@ -60,7 +60,7 @@ To run a benchmark once, and use the result from `mako-stub` for plotting:

1. Retrieve results from mako-stub using the script in
[knative/pkg](https://github.com/knative/pkg/blob/master/test/mako/stub-sidecar/read_results.sh)
where `pod_name` is the name of the aggreator pod:
where `pod_name` is the name of the aggregator pod:

```
bash "$GOPATH/src/knative.dev/pkg/test/mako/stub-sidecar/read_results.sh" "$pod_name" perf-eventing ${mako_port:-10001} ${timeout:-120} ${retries:-100} ${retries_interval:-10} "$output_file"
Expand Down

0 comments on commit 60c1987

Please sign in to comment.