Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pingsource v1beta1 #3607

Merged
merged 4 commits into from
Jul 28, 2020
Merged

Pingsource v1beta1 #3607

merged 4 commits into from
Jul 28, 2020

Conversation

lionelvillard
Copy link
Member

@lionelvillard lionelvillard commented Jul 16, 2020 •
edited
Loading

Part of #3606

Proposed Changes

  • Add new timezone field

Release Note

PingSource now supports setting the time zone.

Docs

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Jul 16, 2020
@knative-prow-robot knative-prow-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Jul 16, 2020
@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 16, 2020
@lionelvillard lionelvillard changed the title Pingsource v1beta1 WIP: Pingsource v1beta1 Jul 16, 2020
@knative-prow-robot knative-prow-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 16, 2020
@lgtm-com
Copy link

lgtm-com bot commented Jul 16, 2020

This pull request introduces 1 alert when merging d6c5ea2 into 1fad94b - view on LGTM.com

new alerts:

  • 1 for Useless assignment to local variable

@aliok
Copy link
Member

aliok commented Jul 17, 2020

/assign

@lionelvillard lionelvillard changed the title WIP: Pingsource v1beta1 Pingsource v1beta1 Jul 17, 2020
@knative-prow-robot knative-prow-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 17, 2020
@vaikas
Copy link
Contributor

vaikas commented Jul 18, 2020

Can you edit the PR description to indicate that you're adding a new feature for release notes?
Also for all the new conversions, I think we should just add the fuzz functions, something like this:
#3574
The conversion tests as they stand are pretty minimal, and we've hit problems in the past with them.

@lionelvillard
Copy link
Member Author

thanks @vaikas, added the release notes.

I'll add the fuzz functions in the conversion PR.

@capri-xiyue, @bharattkukreja did you do this for APIServerSource and ContainerSource?

@aliok This is ready to go. Can you take a look at it?

@lgtm-com
Copy link

lgtm-com bot commented Jul 20, 2020

This pull request introduces 1 alert when merging a2cf408 into f6fa903 - view on LGTM.com

new alerts:

  • 1 for Useless assignment to local variable

@bharattkukreja
Copy link
Contributor

@lionelvillard Not yet for ContainerSource

@lionelvillard
Copy link
Member Author

/hold

Rethinking this. PingSource v1alphaX already supports timezone via CRON_TZ (or TZ) in the schedule. Maybe that's good enough and all what we need to do is updating the documentation.

I think I would still prefer to make it explicit in the spec. Before doing that I'd like to gather people feedback.

@knative-prow-robot knative-prow-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 20, 2020
@lionelvillard
Copy link
Member Author

/unhold

Talked about during the Source WG meeting and no push-back on adding timezone as a field. Let's start with this and we might add more alarm-kind of feature later on.

@knative-prow-robot knative-prow-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 22, 2020
aliok
aliok reviewed Jul 23, 2020
View reviewed changes
Copy link
Member

@aliok aliok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a few comments

@lionelvillard
Copy link
Member Author

@aliok thanks for the review! It should be all good now

@knative-metrics-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-knative-eventing-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/sources/v1beta1/ping_conversion.go Do not exist 100.0%
pkg/apis/sources/v1beta1/ping_defaults.go Do not exist 100.0%
pkg/apis/sources/v1beta1/ping_lifecycle.go Do not exist 68.0%
pkg/apis/sources/v1beta1/ping_types.go Do not exist 100.0%
pkg/apis/sources/v1beta1/ping_validation.go Do not exist 100.0%

@lionelvillard
Copy link
Member Author

/test pull-knative-eventing-integration-tests

aliok
aliok approved these changes Jul 28, 2020
View reviewed changes
Copy link
Member

@aliok aliok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 28, 2020
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aliok, lionelvillard

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-test-reporter-robot
Copy link

The following jobs failed:

Test name Triggers Retries
pull-knative-eventing-integration-tests 0/3

Failed non-flaky tests preventing automatic retry of pull-knative-eventing-integration-tests:

test/e2e.TestPingSourceV1Alpha2EventTypes

@aliok
Copy link
Member

aliok commented Jul 28, 2020

/retest

@knative-prow-robot knative-prow-robot merged commit 5dec79f into knative:master Jul 28, 2020
@aavarghese aavarghese mentioned this pull request Sep 1, 2020
Merged
@lionelvillard lionelvillard deleted the pingsource-v1beta1 branch September 3, 2020 15:29
@lionelvillard lionelvillard restored the pingsource-v1beta1 branch September 3, 2020 15:42
@lionelvillard lionelvillard deleted the pingsource-v1beta1 branch September 3, 2020 15:59
@aliok aliok mentioned this pull request Sep 25, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aliok aliok aliok approved these changes

@nlopezgi nlopezgi Awaiting requested review from nlopezgi

Assignees

@aliok aliok

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@lionelvillard @aliok @vaikas @bharattkukreja @knative-metrics-robot @knative-prow-robot @knative-test-reporter-robot @googlebot