Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move pingsource to v1beta1 umbrella issue #3606

Closed
7 tasks done
lionelvillard opened this issue Jul 16, 2020 · 5 comments
Closed
7 tasks done

Move pingsource to v1beta1 umbrella issue #3606

lionelvillard opened this issue Jul 16, 2020 · 5 comments
Assignees
@lionelvillard
Labels
area/api area/sources kind/feature-request priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Milestone
v0.18.0

Comments

@lionelvillard
Copy link
Member

lionelvillard commented Jul 16, 2020 •
edited
Loading

Problem
We need to promote PingSource to v1beta1.

  • v1beta1 types with UTs
  • add new version to CRD
  • defaulting and conversion webhook
  • Update docs and examples (most in knative/docs)
  • Update e2e tests to use v1beta1
  • Migrate reconciler to v1beta1 with UTs
  • Make v1beta the storage version
@lionelvillard lionelvillard self-assigned this Jul 16, 2020
This was referenced Jul 16, 2020
Merged
Closed
@lionelvillard
Copy link
Member Author

Reposting here for extra visibility.

PingSource v1alphaX already supports timezone via CRON_TZ (or TZ) in the schedule. Maybe that's good enough and all what we need to do is updating the documentation.

I think I would still prefer to make it explicit in the spec. Before doing that I'd like to gather people feedback.

@n3wscott @nachocano @vaikas WDYT?

@n3wscott
Copy link
Contributor

adding timezones will make it incompatible with a K8s CronJob?

@lionelvillard
Copy link
Member Author

yes: kubernetes/kubernetes#47202

@lionelvillard
Copy link
Member Author

CronJobber uses a field: https://github.com/hiddeco/cronjobber

@lberk lberk added this to the v0.17.0 milestone Jul 27, 2020
@lberk lberk added area/api area/sources priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels Jul 27, 2020
@lionelvillard lionelvillard mentioned this issue Jul 28, 2020
Merged
@lionelvillard lionelvillard mentioned this issue Aug 11, 2020
Merged
@grantr grantr modified the milestones: v0.17.0, v0.18.0 Aug 25, 2020
@lionelvillard
Copy link
Member Author

all done.

@capri-xiyue capri-xiyue mentioned this issue Sep 29, 2020
Closed
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lionelvillard lionelvillard

Labels
area/api area/sources kind/feature-request priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Projects
None yet
Milestone
v0.18.0
Development

No branches or pull requests
4 participants
@grantr @lberk @lionelvillard @n3wscott