sources.* resources v1beta1 meta umbrella task

[lionelvillard]

Here the list of sources to move to v1beta1, with additional features based on feedback, and tentative assignment:

• ApiServerSource (@capri-xiyue )
  • be able to filter on a resource's name
• ContainerSource (@bharattkukreja)
  - issue here Move ContainerSource to v1beta1 #3426
• PingSource (@lionelvillard)
  • Add support for timezone
  • Maybe add support for firing once only
  • issue here: Move pingsource to v1beta1 umbrella issue #3606
• SinkBinding (@nachocano)
  • issue here: Move SinkBinding to v1beta1 #3544

[capri-xiyue]

I'm willing to work on ApiServerSource. @nachocano @lionelvillard Can you help add my name for the apiserversource? I don't have the permission to modify that part.

[nachocano]

I'm willing to work on ApiServerSource. @nachocano @lionelvillard Can you help add my name for the apiserversource. I don't have the permission to do that part.

Awesome, done! Thanks Xiyue!

[capri-xiyue]

@lionelvillard @n3wscott @nachocano
Just wanna clarify some questions for ApiServerSource.

1. Have the opensource community decided that v1beta1 ApiServerSource is gonna support filtering on a resource's name? Or the additional feature requests needed for v1beta1 ApiServerSource is still under discussion?
2. For the filtering on a resource's name, does it mean that we will have ApiServerSource Spec similar to this:

apiVersion: sources.knative.dev/v1alpha1
kind: ApiServerSource
metadata:
  name: testnamespace
  namespace: default
spec:
  serviceAccountName: events-sa
  mode: Resource
  resources:
    - apiVersion: v1
      kind: Namespace
      name: filternamespace

And it supports send events for add, update, delete of v1 namespace with name filternamespace

3. The addition feature request is for v1beta1, right? Is it ok that I move ApiServerSource to v1beta1 first and then work on the additional feature request?

4. Besides the possible API change needed for additional feature request like filtering on a resource's name, do we need to do any other API change for v1beta1 ApiServerSource?

[lionelvillard]

My take on this:

1. I think we should go for it
2. I would consider supporting field selector which support name selector.
3. yes
4. maybe an optional way to connect to another cluster.

[capri-xiyue]

@lionelvillard Thanks for the clarification!

[nachocano]

Assigning it to Lionel as he is working on the last piece missing, the PingSource updates.
/assign @lionelvillard

[lionelvillard]

PingSource is now done.