Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

actually make subscription.spec.channel immutable #3522

Merged
merged 1 commit into from
Jul 6, 2020
Merged

actually make subscription.spec.channel immutable #3522

merged 1 commit into from
Jul 6, 2020

Conversation

vaikas
Copy link
Contributor

@vaikas vaikas commented Jul 6, 2020

Fixes #3521

Proposed Changes

  • subscription.spec.channel should be immutable, wire the checks through as they should be.

Release Note

- 🐛 Fix bug
Subscription.spec.channel should be immutable, it's even being tested but not actually wired through.

Docs

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Jul 6, 2020
@knative-prow-robot knative-prow-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 6, 2020
@knative-metrics-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-knative-eventing-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/messaging/v1/subscription_validation.go 93.3% 94.1% 0.8

n3wscott
n3wscott reviewed Jul 6, 2020
View reviewed changes
Copy link
Contributor

@n3wscott n3wscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 6, 2020
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: n3wscott, vaikas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit b160498 into knative:master Jul 6, 2020
@vaikas vaikas deleted the subscription.immutable branch July 8, 2020 21:25
@nachocano nachocano mentioned this pull request Jul 16, 2020
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@n3wscott n3wscott n3wscott left review comments

@aliok aliok Awaiting requested review from aliok

@matzew matzew Awaiting requested review from matzew

Assignees

@n3wscott n3wscott

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

subscription.spec.channel should be immutable
5 participants
@vaikas @knative-metrics-robot @knative-prow-robot @n3wscott @googlebot