Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

subscription.spec.channel should be immutable #3521

Closed
vaikas opened this issue Jul 6, 2020 · 0 comments · Fixed by #3522
Closed

subscription.spec.channel should be immutable #3521

vaikas opened this issue Jul 6, 2020 · 0 comments · Fixed by #3522
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@vaikas
Copy link
Contributor

vaikas commented Jul 6, 2020

Describe the bug
subscription.spec.channel should be immutable, but the code is not wired up.

To Reproduce
create subscription, modify channel should fail, but it doesn't.

Knative release version

Additional context
Add any other context about the problem here such as proposed priority
@vaikas vaikas added the kind/bug Categorizes issue or PR as related to a bug. label Jul 6, 2020
@vaikas vaikas mentioned this issue Jul 6, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

actually make subscription.spec.channel immutable vaikas/eventing
1 participant
@vaikas