Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

actually make trigger.spec.broker immutable #3517

Merged
merged 2 commits into from
Jul 7, 2020
Merged

actually make trigger.spec.broker immutable #3517

merged 2 commits into from
Jul 7, 2020

Conversation

vaikas
Copy link
Contributor

@vaikas vaikas commented Jul 6, 2020 •
edited
Loading

Fixes #3515

Proposed Changes

  • Actually wire the CheckImmutableFields to be called for Trigger.

Release Note

- 🐛 Fix bug
The code that was ensuring that trigger.spec.broker field was immutable was never called. Well, except in the unit tests...

Docs

@knative-prow-robot knative-prow-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 6, 2020
n3wscott
n3wscott reviewed Jul 6, 2020
View reviewed changes
Copy link
Contributor

@n3wscott n3wscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 6, 2020
@vaikas vaikas force-pushed the trigger.spec.broker-immutable branch from 0cb0c87 to b82d690 Compare July 6, 2020 23:29
@knative-prow-robot knative-prow-robot removed the lgtm Indicates that a PR is ready to be merged. label Jul 6, 2020
@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Jul 6, 2020
@vaikas
Copy link
Contributor Author

vaikas commented Jul 6, 2020

Rebased...

n3wscott
n3wscott reviewed Jul 6, 2020
View reviewed changes
Copy link
Contributor

@n3wscott n3wscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 6, 2020
@knative-prow-robot knative-prow-robot removed the lgtm Indicates that a PR is ready to be merged. label Jul 6, 2020
n3wscott
n3wscott reviewed Jul 6, 2020
View reviewed changes
Copy link
Contributor

@n3wscott n3wscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 6, 2020
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: n3wscott, vaikas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-metrics-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-knative-eventing-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/eventing/v1/trigger_validation.go 96.3% 96.5% 0.2

@knative-prow-robot knative-prow-robot merged commit 2d1047d into knative:master Jul 7, 2020
@vaikas vaikas deleted the trigger.spec.broker-immutable branch July 8, 2020 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@n3wscott n3wscott n3wscott left review comments

@Harwayne Harwayne Awaiting requested review from Harwayne

@matzew matzew Awaiting requested review from matzew

Assignees

@n3wscott n3wscott

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

trigger.spec.broker should be immutable
5 participants
@vaikas @knative-prow-robot @knative-metrics-robot @n3wscott @googlebot