Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

trigger.spec.broker should be immutable #3515

Closed
vaikas opened this issue Jul 6, 2020 · 0 comments · Fixed by #3517
Closed

trigger.spec.broker should be immutable #3515

vaikas opened this issue Jul 6, 2020 · 0 comments · Fixed by #3517
Assignees
@vaikas
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@vaikas
Copy link
Contributor

vaikas commented Jul 6, 2020

Describe the bug
Trigger.spec.broker should be immutable. There's even code there, but it's not correctly invoked.

Expected behavior
trigger.spec.broker is immutable field.

To Reproduce
create trigger, kubectl edit a broker field, it's accepted.

Knative release version
head

Additional context
Add any other context about the problem here such as proposed priority
@vaikas vaikas added the kind/bug Categorizes issue or PR as related to a bug. label Jul 6, 2020
@vaikas vaikas self-assigned this Jul 6, 2020
This was referenced Jul 6, 2020
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vaikas vaikas

Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

actually make trigger.spec.broker immutable vaikas/eventing
1 participant
@vaikas