Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade test status set to skip if errors found #3180

Merged
merged 1 commit into from
May 21, 2020
Merged

Upgrade test status set to skip if errors found #3180

merged 1 commit into from
May 21, 2020

Conversation

cardil
Copy link
Contributor

@cardil cardil commented May 20, 2020 •
edited
Loading

Fixes #3178

Proposed Changes

  • Upgrade test status set to skip if errors found and FailOnMissingEvents is false
  • Rename TestProbe to more meaningful TestContinuousEventsPropagationWithProber

follow up to #2388

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label May 20, 2020
@knative-prow-robot knative-prow-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. area/test-and-release Test infrastructure, tests or release labels May 20, 2020
@knative-prow-robot
Copy link
Contributor

Hi @cardil. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow-robot knative-prow-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 20, 2020
@lberk
Copy link
Member

lberk commented May 20, 2020

/ok-to-test

@knative-prow-robot knative-prow-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 20, 2020
@lberk
Copy link
Member

lberk commented May 21, 2020

/assign

@cardil cardil force-pushed the bugfix/3178-upgrade-tests-proper-status branch from 41b2242 to 81cda1f Compare May 21, 2020 11:02
@lberk
Copy link
Member

lberk commented May 21, 2020

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label May 21, 2020
vaikas
vaikas reviewed May 21, 2020
View reviewed changes
test/upgrade/prober/prober.go
p.log.Warnf("Silenced FAIL: %v", err)
}
}
if len(errors) > 0 && !p.config.FailOnMissingEvents {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be better to have a different config option for FailOnErrors? Right now it has double meaning and without reading the code it's hard to know that setting that flag results on this behaviour?
Maybe it would be better to either have:

  • FailOnErrors and FailOnMissingEvents config options
  • rename FailOnMissingEvents to FailOnErrors?

I think it's fine to get this in to make progress, just some thoughts.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've missed that. I've should have renamed that to FailOnErrors

@vaikas
Copy link
Contributor

vaikas commented May 21, 2020

/approve

@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cardil, vaikas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 21, 2020
@knative-prow-robot knative-prow-robot merged commit 7b2192f into knative:master May 21, 2020
@cardil cardil mentioned this pull request May 22, 2020
Closed
@cardil cardil deleted the bugfix/3178-upgrade-tests-proper-status branch May 22, 2020 12:50
@lberk lberk mentioned this pull request Sep 1, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matzew matzew matzew left review comments

@lberk lberk lberk left review comments

@vaikas vaikas vaikas left review comments

@chaodaiG chaodaiG Awaiting requested review from chaodaiG

@steuhs steuhs Awaiting requested review from steuhs

Assignees

@lberk lberk

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release Test infrastructure, tests or release cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Upgrade tests should have status of skipped if any issues are found and FailOnMissingEvents is set to false
6 participants
@cardil @knative-prow-robot @lberk @vaikas @matzew @googlebot