Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade tests should have status of skipped if any issues are found and FailOnMissingEvents is set to false #3178

Closed
cardil opened this issue May 20, 2020 · 1 comment · Fixed by #3180
Closed

Upgrade tests should have status of skipped if any issues are found and FailOnMissingEvents is set to false #3178

cardil opened this issue May 20, 2020 · 1 comment · Fixed by #3180
Assignees
@cardil
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@cardil
Copy link
Contributor

cardil commented May 20, 2020

Describe the bug
In PR #2388 upgrade tests have been introduced. They fail due to unresolved #2665. WG decided to merge them, but instead of failing warning is used if FailOnMissingEvents configuration is set to false. It's okay for now, but in that case the TestProbe test should have status of Skipped instead of Pass.

Expected behavior
TestProbe should be skipped if issues are found and FailOnMissingEvents==false

To Reproduce
Run eventing upgrade tests and observe Silended FAIL messages and state of TestProbe.

Knative release version
master
@cardil cardil added the kind/bug Categorizes issue or PR as related to a bug. label May 20, 2020
@cardil cardil mentioned this issue May 20, 2020
Merged
@cardil
Copy link
Contributor Author

cardil commented May 20, 2020

/assign @cardil

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cardil cardil

Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Upgrade test status set to skip if errors found cardil/knative-eventing
1 participant
@cardil