Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V1beta1 reconcile triggers mt #3093

Merged

Conversation

vaikas
Copy link
Contributor

@vaikas vaikas commented May 6, 2020

Fixes #

Proposed Changes

  • Reconcile Triggers using v1beta1.

Release Note

- 🧽 Update or clean up current behavior
Reconcile Triggers as v1beta1 instead of v1alpha1.

Docs

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label May 6, 2020
@knative-prow-robot knative-prow-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels May 6, 2020
@knative-metrics-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-knative-eventing-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/eventing/v1beta1/trigger_lifecycle.go 51.1% 50.0% -1.1
pkg/reconciler/broker/broker.go 81.2% 82.4% 1.3
pkg/reconciler/broker/trigger.go 87.0% 86.9% -0.1
pkg/reconciler/mtbroker/broker.go 73.0% 73.2% 0.2
pkg/reconciler/mtbroker/trigger.go 87.7% 87.6% -0.1

@n3wscott
Copy link
Contributor

n3wscott commented May 6, 2020

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label May 6, 2020
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: n3wscott, vaikas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit a0c6f3b into knative:master May 6, 2020
@vaikas vaikas deleted the v1beta1-reconcile-triggers-mt branch May 6, 2020 19:22
@knative-prow-robot
Copy link
Contributor

@vaikas: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-knative-eventing-build-tests fe79477 link /test pull-knative-eventing-build-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants