-
Notifications
You must be signed in to change notification settings - Fork 592
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Channel broker controller uses v1alpha1 broker and trigger types #3003
Comments
This is in the reconcilers? |
Yes: eventing/pkg/reconciler/broker/broker.go Lines 42 to 49 in a5df82a
|
#3066 |
Ok, triggers are now being reconciled with v1beta1: |
We don't have the v1alpha1 types anymore, so this can be closed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
The channel broker still uses the v1alpha1 types to work with brokers and triggers.
Expected behavior
The channel broker uses v1beta1 types.
Knative release version
0.14.0
Additional context
I'm not sure if this is actually causing any issues, but it seems like it could theoretically cause failed trigger updates since the trigger validation in v1beta1 is different.
Actually that might be a reason to continue using the v1alpha1 types if the v1alpha1 validation is stricter. So maybe this can be closed if it's working as intended:tm:.
The text was updated successfully, but these errors were encountered: