Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Channel broker controller uses v1alpha1 broker and trigger types #3003

Closed
grantr opened this issue Apr 16, 2020 · 6 comments
Closed

Channel broker controller uses v1alpha1 broker and trigger types #3003

grantr opened this issue Apr 16, 2020 · 6 comments
Labels
kind/bug Categorizes issue or PR as related to a bug.
Milestone

Comments

@grantr
Copy link
Contributor

grantr commented Apr 16, 2020

Describe the bug
The channel broker still uses the v1alpha1 types to work with brokers and triggers.

Expected behavior
The channel broker uses v1beta1 types.

Knative release version
0.14.0

Additional context
I'm not sure if this is actually causing any issues, but it seems like it could theoretically cause failed trigger updates since the trigger validation in v1beta1 is different.

Actually that might be a reason to continue using the v1alpha1 types if the v1alpha1 validation is stricter. So maybe this can be closed if it's working as intended:tm:.

@grantr grantr added the kind/bug Categorizes issue or PR as related to a bug. label Apr 16, 2020
@vaikas
Copy link
Contributor

vaikas commented Apr 20, 2020

This is in the reconcilers?

@grantr
Copy link
Contributor Author

grantr commented Apr 20, 2020

Yes:

duckv1alpha1 "knative.dev/eventing/pkg/apis/duck/v1alpha1"
"knative.dev/eventing/pkg/apis/eventing"
"knative.dev/eventing/pkg/apis/eventing/v1alpha1"
messagingv1beta1 "knative.dev/eventing/pkg/apis/messaging/v1beta1"
clientset "knative.dev/eventing/pkg/client/clientset/versioned"
brokerreconciler "knative.dev/eventing/pkg/client/injection/reconciler/eventing/v1alpha1/broker"
eventinglisters "knative.dev/eventing/pkg/client/listers/eventing/v1alpha1"
messaginglisters "knative.dev/eventing/pkg/client/listers/messaging/v1alpha1"

@vaikas
Copy link
Contributor

vaikas commented May 4, 2020

#3066
Let's just hold off on this work until 0.16 for Broker. In 0.15 we can reconcile Triggers using v1beta1.

@vaikas vaikas added this to the v0.16.0 milestone May 4, 2020
@vaikas
Copy link
Contributor

vaikas commented May 6, 2020

Ok, triggers are now being reconciled with v1beta1:
#3093

@matzew
Copy link
Member

matzew commented Jun 17, 2020

@vaikas @grantr - see #3238

@grantr
Copy link
Contributor Author

grantr commented Jun 17, 2020

We don't have the v1alpha1 types anymore, so this can be closed

@grantr grantr closed this as completed Jun 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

No branches or pull requests

3 participants