Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport: Adding webhook details to eventtypes CRD #3064

Merged
merged 1 commit into from
Apr 30, 2020
Merged

Backport: Adding webhook details to eventtypes CRD #3064

merged 1 commit into from
Apr 30, 2020

Conversation

matzew
Copy link
Member

@matzew matzew commented Apr 29, 2020

Signed-off-by: Matthias Wessendorf mwessend@redhat.com

Fixes #2999 and porting to 0.14

Proposed Changes

  • Adding webhook details to eventtypes CRD

Got now:

{"level":"info","ts":"2020-04-29T08:22:58.949Z","logger":"eventing-webhook","caller":"conversion/reconciler.go:104","msg":"CRD is up to date","commit":"b17b158","knative.dev/traceid":"f02aacc1-e080-4e2b-ad15-65741f0858e6","knative.dev/key":"eventtypes.eventing.knative.dev"}

Release Note

- 🐛 Fix bug adding webhook details to eventypes CRD for conversion

Docs

@matzew
☁️ Adding webhook details to eventtypes CRD
80310a7 
Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>
@knative-prow-robot knative-prow-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 29, 2020
@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Apr 29, 2020
@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 29, 2020
@matzew matzew mentioned this pull request Apr 29, 2020
Closed
@matzew
Copy link
Member Author

matzew commented Apr 29, 2020

/assign @grantr

grantr
grantr approved these changes Apr 30, 2020
View reviewed changes
Copy link
Contributor

@grantr grantr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 30, 2020
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: grantr, matzew

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit f8b42c3 into knative:release-0.14 Apr 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grantr grantr grantr approved these changes

@nachocano nachocano Awaiting requested review from nachocano

Assignees

@grantr grantr

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@matzew @knative-prow-robot @grantr @googlebot