Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

eventtypes isn't configured for webhook conversion #2999

Closed
matzew opened this issue Apr 16, 2020 · 3 comments · Fixed by #3063
Closed

eventtypes isn't configured for webhook conversion #2999

matzew opened this issue Apr 16, 2020 · 3 comments · Fixed by #3063
Assignees
@matzew
Labels
kind/bug Categorizes issue or PR as related to a bug. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Milestone
v0.15.0

Comments

@matzew
Copy link
Member

matzew commented Apr 16, 2020

Describe the bug

Installing 0.14 on 1.18, I am getting:

{
  "level": "error",
  "ts": "2020-04-16T09:13:51.112Z",
  "logger": "eventing-webhook",
  "caller": "controller/controller.go:409",
  "msg": "Reconcile error",
  "commit": "02bc516",
  "error": "custom resource \"eventtypes.eventing.knative.dev\" isn't configured for webhook conversion",
  "stacktrace": "knative.dev/eventing/vendor/knative.dev/pkg/controller.(*Impl).handleErr\n\tknative.dev/eventing/vendor/knative.dev/pkg/controller/controller.go:409\nknative.dev/eventing/vendor/knative.dev/pkg/controller.(*Impl).processNextWorkItem\n\tknative.dev/eventing/vendor/knative.dev/pkg/controller/controller.go:395\nknative.dev/eventing/vendor/knative.dev/pkg/controller.(*Impl).Run.func2\n\tknative.dev/eventing/vendor/knative.dev/pkg/controller/controller.go:343"
}
@matzew matzew added the kind/bug Categorizes issue or PR as related to a bug. label Apr 16, 2020
@vaikas vaikas added this to the v0.15.0 milestone Apr 20, 2020
@vaikas vaikas added the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label Apr 20, 2020
@grantr
Copy link
Contributor

grantr commented Apr 27, 2020

@matzew are you interested in looking at this?

This was referenced Apr 29, 2020
Merged
Merged
@matzew
Copy link
Member Author

matzew commented Apr 29, 2020

@grantr two PRs:

@matzew
Copy link
Member Author

matzew commented Apr 29, 2020

/assign @matzew

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@matzew matzew

Labels
kind/bug Categorizes issue or PR as related to a bug. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Projects
None yet
Milestone
v0.15.0
Development

Successfully merging a pull request may close this issue.

Adding webhook details to eventtypes CRD matzew/eventing
3 participants
@grantr @matzew @vaikas