Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-0.14] do not specify replicas (#3022) #3024

Merged
merged 1 commit into from
Apr 21, 2020
Merged

[release-0.14] do not specify replicas (#3022) #3024

merged 1 commit into from
Apr 21, 2020

Conversation

houshengbo
Copy link

@houshengbo houshengbo commented Apr 20, 2020 •
edited
Loading

Authored-By: Ville Aikas vaikas@vmware.com

Fixes #

Proposed Changes

Release Note

Docs

@knative-prow-robot knative-prow-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 20, 2020
@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added the cla: no Indicates the PR's author has not signed the CLA. label Apr 20, 2020
@houshengbo houshengbo changed the title do not specify replicas (#3022) [release-0.14] do not specify replicas (#3022) Apr 20, 2020
@vaikas
Copy link
Contributor

vaikas commented Apr 20, 2020

I consent
@googlebod I fixed it.

@vaikas
Copy link
Contributor

vaikas commented Apr 20, 2020

I consent.

@houshengbo
Copy link
Author

@googlebot I fixed it.

@vaikas
Copy link
Contributor

vaikas commented Apr 20, 2020

@googlebot I consent

@vaikas
do not specify replicas (knative#3022)
59308e6 
* do not specify replicas

* oops, wrong one
@vaikas
Copy link
Contributor

vaikas commented Apr 20, 2020

/lgtm
/approve

@knative-prow-robot knative-prow-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 20, 2020
@knative-prow-robot knative-prow-robot removed the lgtm Indicates that a PR is ready to be merged. label Apr 20, 2020
@vaikas
Copy link
Contributor

vaikas commented Apr 20, 2020

@googlebot I consent

@houshengbo
Copy link
Author

@googlebot I fixed it.

@vaikas
Copy link
Contributor

vaikas commented Apr 20, 2020

@googlebot I fixed it.
@googlebot I consent
@googlebot I consent.

@houshengbo
Copy link
Author

/test pull-knative-eventing-integration-tests

@grantr grantr added cla: yes Indicates the PR's author has signed the CLA. and removed cla: no Indicates the PR's author has not signed the CLA. labels Apr 20, 2020
@googlebot
Copy link

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

matzew
matzew approved these changes Apr 21, 2020
View reviewed changes
Copy link
Member

@matzew matzew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 21, 2020
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: houshengbo, matzew, vaikas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit 4c05c4f into knative:release-0.14 Apr 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matzew matzew matzew approved these changes

@Harwayne Harwayne Awaiting requested review from Harwayne

@lionelvillard lionelvillard Awaiting requested review from lionelvillard

Assignees

@matzew matzew

@vaikas vaikas

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@houshengbo @googlebot @vaikas @knative-prow-robot @matzew @grantr