Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

do not specify replicas #3022

Merged
merged 2 commits into from
Apr 20, 2020
Merged

do not specify replicas #3022

merged 2 commits into from
Apr 20, 2020

Conversation

vaikas
Copy link
Contributor

@vaikas vaikas commented Apr 20, 2020 •
edited
Loading

Fixes #3019

Proposed Changes

Release Note

Docs

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Apr 20, 2020
@knative-prow-robot knative-prow-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 20, 2020
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vaikas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 20, 2020
houshengbo
houshengbo reviewed Apr 20, 2020
View reviewed changes
Copy link

@houshengbo houshengbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 20, 2020
@AceHack
Copy link
Contributor

AceHack commented Apr 20, 2020

Can we remove replicas for all deployments?

@AceHack
Copy link
Contributor

AceHack commented Apr 20, 2020

As long as deployments have replicas specified the operator will force them to stay at the specified replica count. I will have no ability to manually scale things myself.

@houshengbo
Copy link

/test pull-knative-eventing-integration-tests

@houshengbo
Copy link

@AceHack Serving operator is able to configure the number of replicas for (some) deployments and HPAs. We will extend that capability to eventing, as we move on to a consolidated operator.
We should remove replicas for the deployment with HPA associated, but not from the deployments without HPA.

@AceHack
Copy link
Contributor

AceHack commented Apr 20, 2020 •
edited
Loading

@AceHack Serving operator is able to configure the number of replicas for (some) deployments and HPAs. We will extend that capability to eventing, as we move on to a consolidated operator.
We should remove replicas for the deployment with HPA associated, but not from the deployments without HPA.

Can I count on any replicas without HPA will be able to be controlled by the operator?
Also for the ones with HPA I would like to be able to control their min and max with the operator.

@knative-prow-robot knative-prow-robot merged commit a5df82a into knative:master Apr 20, 2020
houshengbo pushed a commit to houshengbo/eventing that referenced this pull request Apr 20, 2020
@vaikas
do not specify replicas (knative#3022)
c728049 
* do not specify replicas

* oops, wrong one
houshengbo pushed a commit to houshengbo/eventing that referenced this pull request Apr 20, 2020
@vaikas
do not specify replicas (knative#3022)
59308e6 
* do not specify replicas

* oops, wrong one
knative-prow-robot pushed a commit that referenced this pull request Apr 21, 2020
@vaikas
do not specify replicas (#3022) (#3024)
4c05c4f 
* do not specify replicas

* oops, wrong one

Co-authored-by: Ville Aikas <11279988+vaikas@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@houshengbo houshengbo houshengbo left review comments

@liu-cong liu-cong Awaiting requested review from liu-cong

@matzew matzew Awaiting requested review from matzew

Assignees

@houshengbo houshengbo

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Broker ingress constantly scaled up and down in 0.14.0
5 participants
@vaikas @knative-prow-robot @AceHack @houshengbo @googlebot