Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracecontext propagation should be used instead of B3 #2559

Closed
ian-mi opened this issue Feb 13, 2020 · 0 comments · Fixed by #2780
Closed

Tracecontext propagation should be used instead of B3 #2559

ian-mi opened this issue Feb 13, 2020 · 0 comments · Fixed by #2780
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@ian-mi
Copy link
Contributor

ian-mi commented Feb 13, 2020

Describe the bug
The distributed tracing extension states that the traceparent and tracestate headers must be used to propagate tracing attributes.

Expected behavior
Trace context sent in W3C tracecontext format should be propagated by eventing components.

To Reproduce
Send events using ochttp tracecontext propagation:

t, _ = cloudevents.NewHTTPTransport(...)
t.Client = &http.Client{Transport: &ochttp.Transport{Propagation: &tracecontext.HTTPFormat{}}}

Events sent with this transport have disconnected traces as trace context is not propagated.

Knative release version
Release version 0.12

Additional context
May be appropriate to handle this in the cloudevents SDK instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant