Update Cloudevents SDK to v1.1.2 #2684
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knative-prow-robot
added
the
size/XL
mattmoor
reviewed
Mar 2, 2020
|
/hold need to relax some test assertions |
knative-prow-robot
added
do-not-merge/hold
mattmoor
reviewed
Mar 2, 2020
|
I will make 1.1.2 for you today |
ian-mi
changed the title
mattmoor
reviewed
Mar 7, 2020
mattmoor
reviewed
Mar 7, 2020
|
|
||
| The MIT License (MIT) | ||
|
|
||
| Copyright (c) 2016 |
There was a problem hiding this comment.
Remove trailing whitespace:
Suggested change
| Copyright (c) 2016 | |
| Copyright (c) 2016 |
|
Yes, #2046 will need to be resolved before the SDK version can be upgraded since v1.1 adds new trace handling. I am starting on that now. |
|
/retest |
2 similar comments
|
/retest |
|
/retest |
|
/unhold |
knative-prow-robot
removed
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ian-mi, n3wscott The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow-robot
added
the
approved
vaikas
pushed a commit
to vaikas/eventing
that referenced
this pull request
Mar 17, 2020
* Update Cloudevents SDK to v1.1.2 * Ignore ce-traceparent headers in event_dispatcher_test.go
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SDK version 1.1 adds distributed trace extension handling so some tests will need to be updated to expect this extension.
Touches #2559