Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Verify that no channels use v1alpha1 Channelable #3881

Closed
grantr opened this issue Aug 19, 2020 · 6 comments
Closed

Verify that no channels use v1alpha1 Channelable #3881

grantr opened this issue Aug 19, 2020 · 6 comments
Assignees
@n3wscott
Labels
area/channels kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Milestone
v0.19.0

Comments

@grantr
Copy link
Contributor

grantr commented Aug 19, 2020

To remove v1alpha1 Channelable we need to verify that no channels are using it.

List of channels off the top of my head:
@grantr grantr added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Aug 19, 2020
@grantr grantr added this to the v0.18.0 milestone Aug 19, 2020
@grantr
Copy link
Contributor Author

grantr commented Aug 24, 2020

@n3wscott my memory is that you offered to work on this (thanks!)

@grantr grantr added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. area/channels labels Aug 24, 2020
@lberk lberk modified the milestones: v0.18.0, v0.19.0 Oct 5, 2020
@lberk
Copy link
Member

lberk commented Oct 5, 2020

@n3wscott was there any progress on this issue? is v1alpha1 still supported and do you still have bandwidth to look into this issue?

@n3wscott
Copy link
Contributor

n3wscott commented Oct 6, 2020

I do, let me get it tomorrow.

@grantr grantr mentioned this issue Oct 7, 2020
Closed
@vaikas
Copy link
Contributor

vaikas commented Oct 26, 2020

@n3wscott now that natss has been moved off of v1alpha1, is there anything else that needs to be done?

@n3wscott
Copy link
Contributor

n3wscott commented Nov 2, 2020

I think we are good to go.

/close

@knative-prow-robot
Copy link
Contributor

@n3wscott: Closing this issue.

In response to this:

I think we are good to go.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@n3wscott n3wscott

Labels
area/channels kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Projects
None yet
Milestone
v0.19.0
Development

No branches or pull requests
5 participants
@grantr @lberk @vaikas @n3wscott @knative-prow-robot