-
Notifications
You must be signed in to change notification settings - Fork 74
Remove v1alpha1 support for our Resources #1544
Comments
This should be done before #1413 |
@bharattkukreja this will involve removing a bunch of code and update necessary docs if needed |
I did some investigation. Since we haven't had any migration tool before, there might be some customers still using the old cluster with v1alpha1 as the storage version for some sources. If we remove v1alpha1 support before these users migrate their storage version, their side will be crashed. I created a cluster with v1alpha1 as the storage version and serves v1beta1 and v1, then upgrade my cluster without v1alpha1 support (with v1alpha1.served=false, v1alpha1.storage=false), then the existing pods which stored as v1alpha1 will be crashed by
The root cause is that it needs the conversion logic from v1alpha1 to a higher version, but v1alpha1's logic is removed.
|
Synced with @nachocano offline. We agreed that
So this issue will be blocked until 0.19. |
Removing the milestone here, as this is blocked |
@nachocano Is there anyone planning to pick up this? If not, I can go for this. |
I was thinking of giving this to @eclipselu but he has some other issues to work on first. If you are free and want to go for it, you are more than welcome to do so. Otherwise we can wait a bit |
Ok. Thanks for clarifying! Just want to see if we need help with this as it was unassigned. But yeah this is a great issue for ramping up. Let's see if Lu has free cycle then. Please let me know if I can help later. |
The v1alpha Channelable duck is likely to be removed in 0.19 (knative/eventing#3881). The v1alpha1 PubSub Channel uses v1alpha1 Channelable, but v1beta1 Channel does not. If we can't drop support for v1alpha1 Channel by 0.19 (I'm not sure we can, since we need to do a post-install job to convert), then we'll need to figure out how to keep v1alpha1 channelable code (by copying it into this repo) OR upgrade v1alpha1 Channel to use v1beta1 channelable. |
@eclipselu points out that we have a pre-install job in 0.18 that converts all v1alpha1 Channels to v1beta1 (#1653). So it should be safe to drop v1alpha1 Channel in 0.19. |
I actually think we should consider switching the pre-install job for 0.18 that was just created and move it to a post install job. Pre-install jobs are heavily discouraged. |
Closing as the necessary PRs are merged, this is scheduled to release in v0.19. Only BrokerCell is in v1alpha1 now since this is the only version it supports. |
Problem
In #1435, we agreed to remove v1alpha1 versions of all our resources.
We should do this after 0.17 cuts.
We should add a migration tool for our users to run before upgrading to 0.18, so that we can move all of their resources to v1beta1 (or v1).
Persona:
Developer
Exit Criteria
v1alpha1 is not served and is removed from our codebase.
** Additional Context **
See #1435 for more context
The text was updated successfully, but these errors were encountered: