Skip to content
This repository has been archived by the owner on Jun 19, 2022. It is now read-only.

Mark v1alpha1 being Deprecated #1547

Closed
nachocano opened this issue Aug 4, 2020 · 5 comments · Fixed by #1562
Closed

Mark v1alpha1 being Deprecated #1547

nachocano opened this issue Aug 4, 2020 · 5 comments · Fixed by #1562
Assignees
Labels
Milestone

Comments

@nachocano
Copy link
Member

Problem
We decided to remove v1alpha1 support after 0.17 cuts. We should document in the release notes that we will be removing it. Further, we should have a deprecation warning in the status of the resources, probably set in the v1alpha1 conversion logic.

Persona:
Developer

Exit Criteria
Mark v1alpha1 to be deprecated and state in the release notes that this will be remove in 0.18.

Additional context (optional)
See #1544
and #1435

@nachocano nachocano added the kind/feature-request New feature or request label Aug 4, 2020
@nachocano
Copy link
Member Author

We should add a Deprecated status condition, similar to what this does:
https://github.com/knative/eventing/pull/3141/files#diff-99d1987d2919a2cce497502d2ecee2b0R218

But we should probably add it in the v1alpha1 conversion logic...

@nachocano
Copy link
Member Author

fyi @danyinggu in case you are interested and have some cycles

@danyinggu
Copy link
Contributor

danyinggu commented Aug 4, 2020

@nachocano Sure, I am definitely willing to work on it. A quick question: should it be done after v1alpha1 is removed (#1544), or these are two separate issues that can be done in parallel, or all of these should be completed altogether?

@danyinggu danyinggu self-assigned this Aug 4, 2020
@nachocano
Copy link
Member Author

@nachocano Sure, I am definitely willing to work on it. A quick question: should it be done after v1alpha1 is removed (#1544), or these are two separate issues that can be done in parallel, or all of these should be completed altogether?

Great! This should be done first and before 0.17 cuts. After the cut, we remove the support for v1alpha1 for 0.18.

@akashrv akashrv added this to the Backlog milestone Aug 4, 2020
@capri-xiyue
Copy link
Contributor

capri-xiyue commented Aug 4, 2020

@danyinggu You can also take this PR as an example https://github.com/knative/eventing/pull/2107/files#diff-e18136aeccdc97c7dda5625ba2457979 (check pkg/apis/sources/v1alpha1/cron_job_lifecycle.go)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants