Authenticate Requests from ApiServerSources #5423
knative-style.yaml
on: pull_request
style
/
changes
3s
style
/
...
/
Auto-format and Check
14s
style
/
...
/
Lint
35s
style
/
...
/
Do Not Submit
4s
style
/
...
/
shell
0s
style
/
...
/
yaml
0s
style
/
...
/
github_actions
0s
Matrix: style / Golang / Boilerplate Check
Annotations
12 errors and 10 warnings
style / Golang / Auto-format and Check:
pkg/adapter/apiserver/delegate.go#L1
Please run goimports.
diff --git a/pkg/adapter/apiserver/delegate.go b/pkg/adapter/apiserver/delegate.go
index f1f595e..2d48c21 100644
--- a/pkg/adapter/apiserver/delegate.go
+++ b/pkg/adapter/apiserver/delegate.go
@@ -18,6 +18,7 @@ package apiserver
import (
"context"
+
cloudevents "github.com/cloudevents/sdk-go/v2"
"github.com/google/uuid"
"go.uber.org/zap"
|
style / Golang / Auto-format and Check:
pkg/adapter/v2/cloudevents.go#L1
Please run goimports.
diff --git a/pkg/adapter/v2/cloudevents.go b/pkg/adapter/v2/cloudevents.go
index 2e43c17..3e81603 100644
--- a/pkg/adapter/v2/cloudevents.go
+++ b/pkg/adapter/v2/cloudevents.go
@@ -20,12 +20,13 @@ import (
"context"
"errors"
"fmt"
- "k8s.io/apimachinery/pkg/types"
- "knative.dev/eventing/pkg/auth"
nethttp "net/http"
"net/url"
"time"
+ "k8s.io/apimachinery/pkg/types"
+ "knative.dev/eventing/pkg/auth"
+
cloudevents "github.com/cloudevents/sdk-go/v2"
ceclient "github.com/cloudevents/sdk-go/v2/client"
"github.com/cloudevents/sdk-go/v2/event"
|
style / Golang / Auto-format and Check:
pkg/auth/serviceaccount.go#L1
Please run goimports.
diff --git a/pkg/auth/serviceaccount.go b/pkg/auth/serviceaccount.go
index 4c81189..37f37fd 100644
--- a/pkg/auth/serviceaccount.go
+++ b/pkg/auth/serviceaccount.go
@@ -19,9 +19,10 @@ package auth
import (
"context"
"fmt"
- rbacv1 "k8s.io/api/rbac/v1"
"strings"
+ rbacv1 "k8s.io/api/rbac/v1"
+
"go.uber.org/zap"
v1 "k8s.io/api/core/v1"
apierrs "k8s.io/apimachinery/pkg/api/errors"
|
style / Golang / Auto-format and Check:
pkg/reconciler/apiserversource/resources/receive_adapter.go#L1
Please run goimports.
diff --git a/pkg/reconciler/apiserversource/resources/receive_adapter.go b/pkg/reconciler/apiserversource/resources/receive_adapter.go
index 2c48292..edc8f81 100644
--- a/pkg/reconciler/apiserversource/resources/receive_adapter.go
+++ b/pkg/reconciler/apiserversource/resources/receive_adapter.go
@@ -19,6 +19,7 @@ package resources
import (
"encoding/json"
"fmt"
+
"knative.dev/eventing/pkg/adapter/v2"
appsv1 "k8s.io/api/apps/v1"
|
style / Golang / Auto-format and Check:
test/auth/features/oidc/apiserversource.go#L1
Please run goimports.
diff --git a/test/auth/features/oidc/apiserversource.go b/test/auth/features/oidc/apiserversource.go
index 99bc5dc..7b6a5bd 100644
--- a/test/auth/features/oidc/apiserversource.go
+++ b/test/auth/features/oidc/apiserversource.go
@@ -18,6 +18,7 @@ package oidc
import (
"context"
+
"github.com/cloudevents/sdk-go/v2/test"
rbacv1 "k8s.io/api/rbac/v1"
v1 "knative.dev/eventing/pkg/apis/sources/v1"
|
style / Golang / Auto-format and Check
Process completed with exit code 1.
|
style / Golang / Boilerplate Check (go):
pkg/reconciler/apiserversource/resources/role_binding.go#L8
[Go headers] reported by reviewdog 🐶
found mismatched boilerplate lines:
Raw Output:
pkg/reconciler/apiserversource/resources/role_binding.go:8: found mismatched boilerplate lines:
{[]string}[0]:
-: "\thttp://www.apache.org/licenses/LICENSE-2.0"
+: " http://www.apache.org/licenses/LICENSE-2.0"
|
style / Golang / Boilerplate Check (go)
Process completed with exit code 1.
|
style / Golang / Lint:
pkg/auth/serviceaccount.go#L103
S1039: unnecessary use of fmt.Sprintf (gosimple)
|
style / Golang / Lint:
pkg/auth/serviceaccount.go#L158
S1039: unnecessary use of fmt.Sprintf (gosimple)
|
style / Golang / Lint:
pkg/auth/serviceaccount.go#L104
printf: fmt.Sprintf call has arguments but no formatting directives (govet)
|
style / Golang / Lint
issues found
|
style / Golang / Auto-format and Check
Restore cache failed: Dependencies file is not found in /home/runner/work/eventing/eventing. Supported file pattern: go.sum
|
style / Golang / Boilerplate Check (go)
The following actions uses node12 which is deprecated and will be forced to run on node16: andstor/file-existence-action@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
style / Golang / Boilerplate Check (go)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
style / Golang / Boilerplate Check (go)
Restore cache failed: Dependencies file is not found in /home/runner/work/eventing/eventing. Supported file pattern: go.sum
|
style / Golang / Boilerplate Check (sh)
The following actions uses node12 which is deprecated and will be forced to run on node16: andstor/file-existence-action@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
style / Golang / Boilerplate Check (sh)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
style / Golang / Boilerplate Check (sh)
Restore cache failed: Dependencies file is not found in /home/runner/work/eventing/eventing. Supported file pattern: go.sum
|
style / Golang / Lint
The following actions uses node12 which is deprecated and will be forced to run on node16: andstor/file-existence-action@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
style / Golang / Lint
Restore cache failed: Dependencies file is not found in /home/runner/work/eventing/eventing. Supported file pattern: go.sum
|
style / Golang / Lint
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|