Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Eventing Trigger Filtering docs #1283

Closed
wants to merge 4 commits into from
Closed

[WIP] Eventing Trigger Filtering docs #1283

wants to merge 4 commits into from

Conversation

grantr
Copy link
Contributor

@grantr grantr commented May 7, 2019

Fixes #1271.

Proposed Changes

/cc @RichieEscarez

grantr added 3 commits May 6, 2019 15:27
@grantr
Add Broker/Trigger to the list of delivery modes
d380cd4 
Most of this document is woefully out of date, but this part not
mentioning Broker/Trigger seemed particularly egregious.
@grantr
Link to further filtering docs
29617b1
@grantr
WIP on filtering docs
25be95a 
Intro and prereqs sections. Other sections still TODO.
@knative-prow-robot knative-prow-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 7, 2019
@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label May 7, 2019
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: grantr
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: samodell

If they are not already assigned, you can assign the PR to them by writing /assign @samodell in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 7, 2019
@RichieEscarez RichieEscarez added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 15, 2019
@grantr
Copy link
Contributor Author

grantr commented May 15, 2019

Advanced Trigger Filtering was delayed to 0.7

@samodell
Copy link
Contributor

samodell commented Jul 2, 2019

@grantr Did trigger filtering go into the 0.7 release?

@samodell samodell removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 2, 2019
@grantr
Copy link
Contributor Author

grantr commented Jul 2, 2019

It did not. Indefinitely delayed.

@samodell
Copy link
Contributor

samodell commented Jul 2, 2019

Got it, thanks!

@rgregg
Copy link
Contributor

rgregg commented Jul 24, 2019

Closing this indefinitely delayed PR. Please open again when we're ready to commit.

@rgregg rgregg closed this Jul 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RichieEscarez RichieEscarez Awaiting requested review from RichieEscarez

Assignees
No one assigned
Labels
cla: yes Indicates the PR's author has signed the CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/eventing size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Document advanced trigger filter for eventing
6 participants
@grantr @knative-prow-robot @samodell @rgregg @googlebot @RichieEscarez