Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document advanced trigger filter for eventing #1271

Closed
RichieEscarez opened this issue May 3, 2019 · 6 comments
Closed

Document advanced trigger filter for eventing #1271

RichieEscarez opened this issue May 3, 2019 · 6 comments
Assignees
Labels
kind/eventing lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. priority/high
Milestone

Comments

@RichieEscarez
Copy link
Contributor

RichieEscarez commented May 3, 2019

What is changing?

Advanced trigger filter proposal

In what release will this take happen (to the best of your knowledge)?

0.6

From knative/eventing#930:
Problem
We need more advanced filtering mechanisms than just exact match on Cloud Event types and sources.

Persona:
Event Consumer

Exit Criteria
Being able to configure advanced filters on triggers, either with CEL or some other language.

Suggestions for where to add this content

  • Update/add/delete necessary info in https://github.com/knative/docs/tree/release-0.5/docs/eventing/README.md
    • And link to new topic (details below)
  • Create new Event Trigger topic
  • Key focal points to address in the document:
    • Try to create sections as follows:
      1. overview/conceptual content
        • Address "why user should use a filter" (ie. Use a filter in your event trigger to reduce and filter out only the attributes of an event that you want sent to the event subscribers.)
      2. requirements/prerequisites (create a "Before you begin" section)
        • list all requirements and link to relevant content
        • Link to CEL -> explain (ie. Trigger filters support expressions written in CEL.)
      3. "how to" info (the "task-oriented" step by step details for creating an event filter in a trigger) -> use a gerund in title (for example Filtering event attributes)
      4. Example(s) (show them how and where they would/can create a filter in their trigger) i see lots in the proposal and it would be most consumable if we could organize these to some degree
      5. Link to what the next logical step would be (and include links to related info) to keep the user moving forward
@grantr
Copy link
Contributor

grantr commented May 15, 2019

This was delayed to the 0.7 release. @RichieEscarez can you please change the milestone? Thanks!

@samodell samodell removed this from the v0.6 docs milestone May 15, 2019
@samodell
Copy link
Contributor

samodell commented Sep 3, 2019

@grantr Has this been released yet?

@samodell samodell added this to the Backlog milestone Sep 3, 2019
@knative-housekeeping-robot

Issues go stale after 90 days of inactivity.
Mark the issue as fresh by adding the comment /remove-lifecycle stale.
Stale issues rot after an additional 30 days of inactivity and eventually close.
If this issue is safe to close now please do so by adding the comment /close.

Send feedback to Knative Productivity Slack channel or file an issue in knative/test-infra.

/lifecycle stale

@knative-prow-robot knative-prow-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 3, 2019
@knative-housekeeping-robot

Stale issues rot after 30 days of inactivity.
Mark the issue as fresh by adding the comment /remove-lifecycle rotten.
Rotten issues close after an additional 30 days of inactivity.
If this issue is safe to close now please do so by adding the comment /close.

Send feedback to Knative Productivity Slack channel or file an issue in knative/test-infra.

/lifecycle rotten

@knative-prow-robot knative-prow-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jan 3, 2020
@grantr
Copy link
Contributor

grantr commented Jan 3, 2020

/close

@knative-prow-robot
Copy link
Contributor

@grantr: Closing this issue.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/eventing lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. priority/high
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants