-
Notifications
You must be signed in to change notification settings - Fork 159
Show intermediate update of build steps #309
Show intermediate update of build steps #309
Conversation
/assign @imjasonh |
The following is the coverage report on pkg/.
|
apiVersion: build.knative.dev/v1alpha1 | ||
kind: Build | ||
metadata: | ||
name: test-build-with-more-steps |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have a few tests that happen to specify multiple steps, e.g., test-custom-volume
and test-home-volume
.
It's a real limitation of our integration testing "framework" that the only way we have right now to test things against a real cluster is to send builds and expect them to succeed or fail. Once we have a more "real" framework in place (stolen from knative/serving
no doubt), we can have a test that runs a multi-step build and watches to see multiple status updates.
Until then, I'm not sure this test really adds much, except that it's proof that a build that has two steps succeeds.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I completely agree with you on this.
The rest of this change looks great though, and I can't wait to get updates about the build's status while it's ongoing. /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ImJasonH, shashwathi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Fixes #304
Proposed Changes
waiting
,running
.