Skip to content
This repository has been archived by the owner on Sep 5, 2019. It is now read-only.

Update build with step states during build execution #304

Closed
imjasonh opened this issue Aug 21, 2018 · 1 comment
Closed

Update build with step states during build execution #304

imjasonh opened this issue Aug 21, 2018 · 1 comment
Assignees
Labels
area/api kind/bug Something isn't working

Comments

@imjasonh
Copy link
Member

Expected Behavior

As a build executes on-cluster, watch kubectl get build foo -oyaml should show the current state of completed/ongoing steps.

Actual Behavior

.Spec.Status.StepStates is only updated upon completion of the pod executing the build.

The on-cluster builder implementation uses registerDoneCallback to receive notifications about pod state when the pod completes, but it should also get updates during execution to update its stepStates.

Steps to Reproduce the Problem

  1. Create a build with multiple steps, each of which takes some amount of time (e.g., steps that each sleep 10)
  2. kubectl apply -f the-build.yaml
  3. watch kubectl get build the-build -oyaml
  4. The build's status is not updated until the build completes (successfully or otherwise)
@knative-prow-robot knative-prow-robot added area/api kind/bug Something isn't working labels Aug 21, 2018
@shashwathi
Copy link
Contributor

/assign @shashwathi

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area/api kind/bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants