Fix make gen problem
#582
Fix make gen problem
#582
Conversation
Signed-off-by: Okabe-Rintarou-0 <923048992@qq.com>
Signed-off-by: 923048992@qq.com <923048992@qq.com>
hack/gen_protoc.sh
Outdated
| --privileged=true \ | ||
| -v $ROOT_DIR:/kmesh \ | ||
| --name kmesh-build \ | ||
| ghcr.io/kmesh-net/kmesh-build-${arch}:latest \ |
There was a problem hiding this comment.
Does the build image already support multi arch? @lec-bit
There was a problem hiding this comment.
https://github.com/orgs/kmesh-net/packages/container/package/kmesh-build
We have supported both arm and x86， so can remove arch suffix
There was a problem hiding this comment.
https://github.com/orgs/kmesh-net/packages/container/package/kmesh-build
We have supported both arm and x86， so can remove arch suffix
then we should also remove the arch preffix in make build?
Signed-off-by: 923048992@qq.com <923048992@qq.com>
Okabe-Rintarou-0
force-pushed
the
fix/makegen
branch
from
13bba84 to
384a6a8
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
see 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
| @@ -3,6 +3,7 @@ | |||
| function install_tool () { | |||
| tool=${1} | |||
| if command -v apt > /dev/null; then | |||
| sudo apt-get update | |||
Signed-off-by: 923048992@qq.com <923048992@qq.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hzxuzhonghu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
bug
What this PR does / why we need it:
Fix
make genproblem, upgrate protoc-c to 1.4.x, aligning with the native one in openEuler 23.03.Which issue(s) this PR fixes:
Fixes #571
Special notes for your reviewer:
Does this PR introduce a user-facing change?: