Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make gen generate proto problem #571

Closed
Okabe-Rintarou-0 opened this issue Jul 13, 2024 · 12 comments · Fixed by #582
Closed

make gen generate proto problem #571

Okabe-Rintarou-0 opened this issue Jul 13, 2024 · 12 comments · Fixed by #582
Assignees
Labels
kind/bug Something isn't working

Comments

@Okabe-Rintarou-0
Copy link
Member

What happened:

Run make gen locally produces some differences:
image

[root@localhost kmesh]# protoc --version
libprotoc 3.17.3

What you expected to happen:

How to reproduce it (as minimally and precisely as possible):

Anything else we need to know?:

Environment:

  • Kmesh version:
  • Others:
@Okabe-Rintarou-0 Okabe-Rintarou-0 added the kind/bug Something isn't working label Jul 13, 2024
@hzxuzhonghu
Copy link
Member

what is the result of protoc-c --version

@Okabe-Rintarou-0
Copy link
Member Author

libprotoc 3.17.3

@hzxuzhonghu
Copy link
Member

# protoc --version
libprotoc 3.17.3
# protoc-c --version
protobuf-c 1.3.3
libprotoc 3.12.4

I am running on unbuntu2204.

Should be correlated with

	    apt-get update && apt-get install -y git make clang libbpf-dev llvm linux-tools-generic protobuf-compiler libprotobuf-dev libprotobuf-c-dev protobuf-c-compiler cmake pkg-config

	    yum install -y git make clang llvm libboundscheck protobuf protobuf-c protobuf-c-devel bpftool libbpf libbpf-devel cmake pkg-config


@Okabe-Rintarou-0
Copy link
Member Author

[root@localhost kmesh]# protoc-c --version
protobuf-c 1.4.1
libprotoc 3.14.0

Environment: openEuler 23.03

@Okabe-Rintarou-0
Copy link
Member Author

Maybe we should specify the version.

@Okabe-Rintarou-0
Copy link
Member Author

[root@localhost kmesh]# yum list available protobuf*
Last metadata expiration check: 0:01:36 ago on 2024年07月15日 星期一 13时15分11秒.
Available Packages
protobuf.src                                                                                             3.14.0-6.oe2303                                                                            source    
protobuf.x86_64                                                                                          3.14.0-6.oe2303                                                                            OS        
protobuf.x86_64                                                                                          3.14.0-6.oe2303                                                                            everything
protobuf-bom.noarch                                                                                      3.14.0-6.oe2303                                                                            everything
protobuf-c.src                                                                                           1.4.1-1.oe2303                                                                             source    
protobuf-c.x86_64                                                                                        1.4.1-1.oe2303                                                                             OS        
protobuf-c.x86_64                                                                                        1.4.1-1.oe2303                                                                             everything
protobuf-c-debuginfo.x86_64                                                                              1.4.1-1.oe2303                                                                             debuginfo 
protobuf-c-debugsource.x86_64                                                                            1.4.1-1.oe2303                                                                             debuginfo 
protobuf-c-devel.x86_64                                                                                  1.4.1-1.oe2303                                                                             everything
protobuf-compiler.x86_64                                                                                 3.14.0-6.oe2303                                                                            OS        
protobuf-compiler.x86_64                                                                                 3.14.0-6.oe2303                                                                            everything
protobuf-debuginfo.x86_64                                                                                3.14.0-6.oe2303                                                                            debuginfo 
protobuf-debugsource.x86_64                                                                              3.14.0-6.oe2303                                                                            debuginfo 
protobuf-devel.x86_64                                                                                    3.14.0-6.oe2303                                                                            OS        
protobuf-devel.x86_64                                                                                    3.14.0-6.oe2303                                                                            everything
protobuf-java.noarch                                                                                     3.14.0-6.oe2303                                                                            everything
protobuf-java-util.noarch                                                                                3.14.0-6.oe2303                                                                            everything
protobuf-javadoc.noarch                                                                                  3.14.0-6.oe2303                                                                            everything
protobuf-javalite.noarch                                                                                 3.14.0-6.oe2303                                                                            everything
protobuf-lite.x86_64                                                                                     3.14.0-6.oe2303                                                                            OS        
protobuf-lite.x86_64                                                                                     3.14.0-6.oe2303                                                                            everything
protobuf-lite-devel.x86_64                                                                               3.14.0-6.oe2303                                                                            OS        
protobuf-lite-devel.x86_64                                                                               3.14.0-6.oe2303                                                                            everything
protobuf-parent.noarch                                                                                   3.14.0-6.oe2303                                                                            everything
protobuf2.src                                                                                            2.5.0-3.oe2303                                                                             source    
protobuf2.x86_64                                                                                         2.5.0-3.oe2303                                                                             everything
protobuf2-compiler.x86_64                                                                                2.5.0-3.oe2303                                                                             everything
protobuf2-debuginfo.x86_64                                                                               2.5.0-3.oe2303                                                                             debuginfo 
protobuf2-debugsource.x86_64                                                                             2.5.0-3.oe2303                                                                             debuginfo 
protobuf2-devel.x86_64                                                                                   2.5.0-3.oe2303                                                                             everything
protobuf2-emacs.x86_64                                                                                   2.5.0-3.oe2303                                                                             everything
protobuf2-emacs-el.x86_64                                                                                2.5.0-3.oe2303                                                                             everything
protobuf2-java.x86_64                                                                                    2.5.0-3.oe2303                                                                             everything
protobuf2-javadoc.x86_64                                                                                 2.5.0-3.oe2303                                                                             everything
protobuf2-lite.x86_64                                                                                    2.5.0-3.oe2303                                                                             everything
protobuf2-lite-devel.x86_64                                                                              2.5.0-3.oe2303                                                                             everything
protobuf2-lite-static.x86_64                                                                             2.5.0-3.oe2303                                                                             everything
protobuf2-static.x86_64                                                                                  2.5.0-3.oe2303                                                                             everything
protobuf2-vim.x86_64                                                                                     2.5.0-3.oe2303                                                                             everything

@Okabe-Rintarou-0
Copy link
Member Author

/assign

@Okabe-Rintarou-0
Copy link
Member Author

Okabe-Rintarou-0 commented Jul 15, 2024

image
In openEuler, the protobuf-c version is 1.4.x

@hzxuzhonghu
Copy link
Member

Should check the toos version. Or should run the cmd directly in docker container.

@Okabe-Rintarou-0
Copy link
Member Author

Okabe-Rintarou-0 commented Jul 15, 2024

kmesh-build docker:

protobuf-c 1.4.1
libprotoc 3.19.6

Maybe use kmesh docker container is not ok.

@hzxuzhonghu
Copy link
Member

Whatever, both way is to use a specific version

@hzxuzhonghu
Copy link
Member

We can caccept upgrade the version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants