Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pdfium to 6721 #198

Merged
merged 16 commits into from
Nov 19, 2024
+2,634 −467

Fix 64 bit size_t

b25152c
Select commit
Loading
Failed to load commit list.
Merged

Update pdfium to 6721 #198

Fix 64 bit size_t
b25152c
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Nov 19, 2024 in 0s

75.57% (-0.07%) compared to 8c3d896, passed because coverage increased by 0.05% when compared to adjusted base (75.51%)

View this Pull Request on Codecov

75.57% (-0.07%) compared to 8c3d896, passed because coverage increased by 0.05% when compared to adjusted base (75.51%)

Details

Codecov Report

Attention: Patch coverage is 81.71642% with 98 lines in your changes missing coverage. Please review.

Project coverage is 75.57%. Comparing base (8c3d896) to head (b25152c).

Files with missing lines Patch % Lines
internal/implementation_webassembly/fpdf_edit.go 65.82% 18 Missing and 9 partials ⚠️
internal/implementation_webassembly/fpdf_annot.go 56.36% 16 Missing and 8 partials ⚠️
...rnal/implementation_webassembly/fpdf_structtree.go 79.45% 10 Missing and 5 partials ⚠️
...nternal/implementation_webassembly/fpdf_catalog.go 60.86% 6 Missing and 3 partials ⚠️
...ernal/implementation_cgo/fpdf_edit_experimental.go 89.47% 4 Missing and 2 partials ⚠️
...implementation_cgo/fpdf_structtree_experimental.go 90.16% 4 Missing and 2 partials ⚠️
internal/implementation_cgo/fpdf_annot.go 88.00% 2 Missing and 1 partial ⚠️
internal/implementation_cgo/fpdf_catalog.go 81.25% 2 Missing and 1 partial ⚠️
internal/implementation_webassembly/fpdf_text.go 86.36% 2 Missing and 1 partial ⚠️
internal/implementation_cgo/implementation.go 97.61% 1 Missing ⚠️
... and 1 more
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #198      +/-   ##
==========================================
- Coverage   75.63%   75.57%   -0.07%     
==========================================
  Files         110      110              
  Lines       24784    25156     +372     
==========================================
+ Hits        18746    19011     +265     
- Misses       4257     4329      +72     
- Partials     1781     1816      +35

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚨 Try these New Features:

View more details on Codecov