Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pdfium to 6721 #198

Merged
merged 16 commits into from
Nov 19, 2024
Merged

Update pdfium to 6721 #198

merged 16 commits into from
Nov 19, 2024

Conversation

jerbob92
Copy link
Contributor

@jerbob92 jerbob92 commented Nov 19, 2024

  • Update PDFium to 6721 (including new WASM build using Emscripten 3.1.72)
  • Removed experimental methods:
    • FPDFFont_GetFontName (now FPDFFont_GetBaseFontName and FPDFFont_GetFamilyName)
    • FPDFText_GetTextRenderMode (use FPDFText_GetTextObject and FPDFTextObj_GetTextRenderMode now)
  • Implemented new experimental methods:
    • FPDFAnnot_GetFontColor
    • FPDF_StructElement_Attr_GetValue
    • FPDF_StructElement_Attr_GetChildAtIndex
    • FPDF_StructElement_Attr_CountChildren
    • FPDFText_GetTextObject
    • FPDFFont_GetBaseFontName
    • FPDFFont_GetFamilyName
    • FPDFCatalog_SetLanguage
    • FPDFPageObj_TransformF
    • FPDFPageObj_GetMarkedContentID
  • Change working of structtree functions:
    • FPDF_StructElement_Attr_GetType now expects a FPDF_STRUCTELEMENT_ATTR_VALUE (fetched using FPDF_StructElement_Attr_GetValue)
    • FPDF_StructElement_Attr_GetBooleanValue now expects a FPDF_STRUCTELEMENT_ATTR_VALUE (fetched using FPDF_StructElement_Attr_GetValue)
    • FPDF_StructElement_Attr_GetNumberValue now expects a FPDF_STRUCTELEMENT_ATTR_VALUE (fetched using FPDF_StructElement_Attr_GetValue)
    • FPDF_StructElement_Attr_GetStringValue now expects a FPDF_STRUCTELEMENT_ATTR_VALUE (fetched using FPDF_StructElement_Attr_GetValue)
    • FPDF_StructElement_Attr_GetBlobValue now expects a FPDF_STRUCTELEMENT_ATTR_VALUE (fetched using FPDF_StructElement_Attr_GetValue)

Copy link

codecov bot commented Nov 19, 2024

Codecov Report

Attention: Patch coverage is 81.71642% with 98 lines in your changes missing coverage. Please review.

Project coverage is 75.57%. Comparing base (8c3d896) to head (b25152c).
Report is 17 commits behind head on main.

Files with missing lines Patch % Lines
internal/implementation_webassembly/fpdf_edit.go 65.82% 18 Missing and 9 partials ⚠️
internal/implementation_webassembly/fpdf_annot.go 56.36% 16 Missing and 8 partials ⚠️
...rnal/implementation_webassembly/fpdf_structtree.go 79.45% 10 Missing and 5 partials ⚠️
...nternal/implementation_webassembly/fpdf_catalog.go 60.86% 6 Missing and 3 partials ⚠️
...ernal/implementation_cgo/fpdf_edit_experimental.go 89.47% 4 Missing and 2 partials ⚠️
...implementation_cgo/fpdf_structtree_experimental.go 90.16% 4 Missing and 2 partials ⚠️
internal/implementation_cgo/fpdf_annot.go 88.00% 2 Missing and 1 partial ⚠️
internal/implementation_cgo/fpdf_catalog.go 81.25% 2 Missing and 1 partial ⚠️
internal/implementation_webassembly/fpdf_text.go 86.36% 2 Missing and 1 partial ⚠️
internal/implementation_cgo/implementation.go 97.61% 1 Missing ⚠️
... and 1 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #198      +/-   ##
==========================================
- Coverage   75.63%   75.57%   -0.07%     
==========================================
  Files         110      110              
  Lines       24784    25156     +372     
==========================================
+ Hits        18746    19011     +265     
- Misses       4257     4329      +72     
- Partials     1781     1816      +35     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@jerbob92 jerbob92 merged commit dad2417 into main Nov 19, 2024
38 checks passed
@jerbob92 jerbob92 deleted the feature/update-pdfium-to-6721 branch November 19, 2024 14:32
@jerbob92 jerbob92 changed the title WIP: Update pdfium to 6721 Update pdfium to 6721 Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant