Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid EINTR in readline by repeating poll-call. #403

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Marthog
Copy link

@Marthog Marthog commented Jun 17, 2020

Fixes #402 by repeating the call on EINTR.

@gwenn
Copy link
Collaborator

gwenn commented Jun 17, 2020

Thanks.
But I am not sure we should loop.

@bjorn3
Copy link
Contributor

bjorn3 commented Jun 18, 2020

An EINTR can be caused by any signal, including SIGSTOP, SIGCHLD, SIGWINCH or SIGUSR1.

@gwenn
Copy link
Collaborator

gwenn commented Jun 18, 2020

An EINTR can be caused by any signal, including SIGSTOP, SIGCHLD, SIGWINCH or SIGUSR1.

Indeed!
At least, we should not ignore SIGWINCH.

@gwenn
Copy link
Collaborator

gwenn commented Jul 26, 2020

See #420.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Avoid returning EINTR in PosixRenderer::move_cursor_at_leftmost
3 participants