Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid returning EINTR in PosixRenderer::move_cursor_at_leftmost #402

Closed
Marthog opened this issue Jun 17, 2020 · 0 comments · Fixed by #420 · May be fixed by #403
Closed

Avoid returning EINTR in PosixRenderer::move_cursor_at_leftmost #402

Marthog opened this issue Jun 17, 2020 · 0 comments · Fixed by #420 · May be fixed by #403

Comments

@Marthog
Copy link

Marthog commented Jun 17, 2020

Hello,
I could trace back a weird termination in nushell on linux to an EINTR returned by a poll call in rustyline.

The issue occurs when I run qterminal -e nu, but is timing dependent and may be not reproducible on other devices. Even small changes like additional logging changed the behavior during debugging.

There are multiple potential fixes:

  1. Repeat the call on EINTR.
  2. use sigaction to repeat all interrupted syscalls. This may prevent multiple similar issues, but unfortunately it is a program-wide change.

I will send a pull request soon, with a fix for option 1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant