Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix NoMethodError error on Ruby 2.4 and older. #353

Merged
merged 1 commit into from
Jun 3, 2020

Conversation

Envek
Copy link

@Envek Envek commented Jun 2, 2020

Fixes #352

NoMethodError: private method 'open' called for URI:Module was raised on older rubies as URI.open was added only in Ruby 2.5: https://rubyreferences.github.io/rubychanges/2.5.html#network-and-web

NoMethodError: private method `open' called for URI:Module was raised on older rubies as URI.open was added only in Ruby 2.5: https://rubyreferences.github.io/rubychanges/2.5.html#network-and-web
@kjvarga
Copy link
Owner

kjvarga commented Jun 3, 2020

Thanks for the patch! I'll get this in asap.

@kjvarga kjvarga merged commit 67c1c85 into kjvarga:master Jun 3, 2020
@Envek Envek deleted the fix/old-rubies-uri-open branch June 3, 2020 19:14
@kjvarga
Copy link
Owner

kjvarga commented Jun 3, 2020

Fixed in v6.1.2. Appreciate the quick follow up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

v6.1.1 ping failed under Ruby 2.7
2 participants