-
Notifications
You must be signed in to change notification settings - Fork 278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v6.1.1 ping failed under Ruby 2.7 #352
Comments
Thanks for the report! |
@Envek it looks like this was missed in your implementation. Are you able to suggest a fix? |
Ah, |
So it needs to update to support under Ruby 2.5 or to set 'required Ruby version' to Ruby 2.5 and above. Since I use below Ruby 2.5, I prefer supporting old Ruby versions. |
NoMethodError: private method `open' called for URI:Module was raised on older rubies as URI.open was added only in Ruby 2.5: https://rubyreferences.github.io/rubychanges/2.5.html#network-and-web
Added support for old rubies in #353 @byungjikroh, please note that rubies older than 2.5 are not supported anymore:
So it is better to upgrade anyway |
Sure. Thanks a lot. 😀 |
Fixed in v6.1.2. It's now backwards compatible with older Rubies. Thanks for the report. |
An error about 'Ping failed for Google: #<NoMethodError: private method `open' called for URI:Module>' at v6.1.1 because of a patch to support URI.open instead of depreciated Kernel#open (#342).
But Ruby version below than 2.7 (I'm not sure), there is no URI.open method so it causes errors when ping to Google or Bing.
Please patch to support Kernel#open for Ruby version below than 2.7.
The text was updated successfully, but these errors were encountered: