Tribute to marine primates #887
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
veloman-yunkan
force-pushed
the
seamonkey
branch
from
6685171
to
dccf8da
Compare
Codecov ReportBase: 72.01% // Head: 72.01% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #887 +/- ##
=======================================
Coverage 72.01% 72.01%
=======================================
Files 53 53
Lines 3745 3745
Branches 2093 2093
=======================================
Hits 2697 2697
Misses 1046 1046
Partials 2 2 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
SeaMonkey doesn't yet support ['import.meta'][1]. This change requires that a function `setPermanentGlobalCookie(name, value)` is defined before `setUserLanguage()` (exported by i18n.js) can be called. [1]: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/import.meta
SeaMonkey doesn't yet support [Window.visualViewport][1]. As a result the height of the content iframe element was initialized to the default 150 pixels and never changed. Fortunately there is [Window.innerHeight][2] which is supported from the very first days of the Gecko layout engine. The difference between `Window.visualViewport.height` and `Window.innerHeight` is that the latter also includes - the height of the horizontal scroll bar, if present (but in a correctly implemented ZIM viewer there shouldn't be a horizontal scroll bar for the full web-page, so it's OK) - the height of the on-screen keyboard (which is mostly used on mobile devices where SeaMonkey doesn't run). And it is also arguable if the appearing on-screen keyboard should squeeze the iframe or slide over it (in which latter case it may make more sense to always use `innerHeight` instead of `visualViewport.height`). [1]: https://developer.mozilla.org/en-US/docs/Web/API/Window/visualViewport [2]: https://developer.mozilla.org/en-US/docs/Web/API/Window/innerHeight
The recently introduced ZIM viewer UI language selector looked adequately nice under Firefox without any explicit styling applied. Under SeaMonkey, however, its default look and feel was intolerable, so I used this opportunity to make the UI language selector comply with the current fashion of the ZIM viewer toolbar.
mgautierfr
approved these changes
Feb 8, 2023
That's a pity ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #885
Fixes kiwix/kiwix-tools#592
Doesn't (even try to) fix openzim/zim-tools#311