Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iframe defaults to height: 150px; in older browsers #592

Closed
ghost opened this issue Jan 1, 2023 · 8 comments · Fixed by kiwix/libkiwix#887
Closed

iframe defaults to height: 150px; in older browsers #592

ghost opened this issue Jan 1, 2023 · 8 comments · Fixed by kiwix/libkiwix#887
Assignees
Milestone

Comments

@ghost
Copy link

ghost commented Jan 1, 2023

Using an older browser the iframe that serves the content is only set to 150px high, making the content difficult to read.

This works:

<iframe src="http://en.wikipedia.org" style="height:100%;width:100%;"></iframe>

This does not:

<iframe src="http://en.wikipedia.org"></iframe>

However there is something in the kiwix webpage that doesn't work when I try appending height:100% to the iframe element. I don't know why.

@kelson42
Copy link
Contributor

kelson42 commented Jan 1, 2023

@tim78245 Which exact version of seamonkey do you use? We need to reproduce the bug first.

@kelson42
Copy link
Contributor

kelson42 commented Jan 1, 2023

This CSS spec is interesting https://www.w3.org/TR/CSS2/visudet.html#inline-replaced-height

@ghost
Copy link
Author

ghost commented Jan 1, 2023

@tim78245 Which exact version of seamonkey do you use? We need to reproduce the bug first.

the current version, 2.53.14.

This CSS spec is interesting https://www.w3.org/TR/CSS2/visudet.html#inline-replaced-height

Yes, 150px is the default.

@kelson42
Copy link
Contributor

@veloman-yunkan Could you please make this quick fix?

@veloman-yunkan
Copy link
Collaborator

veloman-yunkan commented Feb 7, 2023

kiwix/libkiwix#871 made the situation for seamonkey even worse (see kiwix/libkiwix#871 (comment)). I will try to make seamonkey happy with kiwix-serve's ZIM viewer again.

@veloman-yunkan
Copy link
Collaborator

Regarding the wrong height of the iframe - the root cause is because seamonkey doesn't recognize window.visualViewport:

TypeError: window.visualViewport is undefined[Learn More]  viewer.js:187:3
  handle_visual_viewport_change http://localhost:8080/ROOT/skin/viewer.js:187:3

@kelson42
Copy link
Contributor

kelson42 commented Feb 7, 2023

@veloman-yunkan So, it's a WONTFIX? Uers have to use a recent browser?

@veloman-yunkan
Copy link
Collaborator

@veloman-yunkan So, it's a WONTFIX? Uers have to use a recent browser?

No. I have already fixed (or rather worked around) the issue reported in this ticket, but it won't make any difference until kiwix/libkiwix#885 is fixed too (which I am working on now).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants