Library::removeBookById() updates the reader list and the search DB #485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `XmlLibraryTest.removeBookByIdDropsTheReader` unit-test fails, demonstrating a bug in `kiwix::Library::removeBookById()`.
This fix makes the `XmlLibraryTest.removeBookByIdDropsTheReader` unit-test pass.
The new unit-test fails with a reason not expected before it was written. The `Library::filter()` operation returns a correct result after the call to `removeBookById()` (this was a surprise!) but it has a side-effect of re-adding an empty book with the id still surviving in the search DB (the emptiness of this re-created book doesn't allow it to pass the other filtering criteria, which explains why the result of `Library::filter()` is correct). Had to add a special check to the new unit-test against that hidden side-effect of `Library::removeBookById()` + `Library::filter()` combination.
This changes how the `XmlLibraryTest.removeBookByIdUpdatesTheSearchDB` unit-test fails.
This fix makes the `XmlLibraryTest.removeBookByIdUpdatesTheSearchDB` unit-test pass.
Codecov Report
@@ Coverage Diff @@
## master #485 +/- ##
==========================================
+ Coverage 63.07% 63.14% +0.07%
==========================================
Files 50 50
Lines 3504 3506 +2
Branches 1770 1771 +1
==========================================
+ Hits 2210 2214 +4
+ Misses 1292 1290 -2
Partials 2 2
Continue to review full report at Codecov.
|
veloman-yunkan
commented
Apr 9, 2021
| @@ -331,7 +331,7 @@ Library::BookIdCollection Library::filter(const Filter& filter) | |||
| { | |||
| BookIdCollection result; | |||
| for(auto id : getBooksByTitleOrDescription(filter)) { | |||
| if(filter.acceptByNonQueryCriteria(m_books[id])) { | |||
There was a problem hiding this comment.
This bug was introduced in #460 because Library::filter() is not declared const.
mgautierfr
approved these changes
Apr 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #478
I added a new test-suite
XmlLibraryTestso that I could make use of theLibrary::getReaderById()method (a library constructed from an OPDS stream doesn't contain local books).